Skip to content

Commit c6d612d

Browse files
authored
Resolve cppcoreguidelines-explicit-virtual-functions (#546)
1 parent c6fbd34 commit c6d612d

13 files changed

+13
-13
lines changed

include/CXXGraph/Edge/DirectedEdge_decl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class DirectedEdge : public Edge<T> {
5252
const std::string &userId,
5353
const std::pair<shared<const Node<T>>, shared<const Node<T>>> &nodepair);
5454
DirectedEdge(const Edge<T> &edge);
55-
virtual ~DirectedEdge() = default;
55+
~DirectedEdge() override = default;
5656
const Node<T> &getFrom() const;
5757
const Node<T> &getTo() const;
5858
const std::optional<bool> isDirected() const override;

include/CXXGraph/Edge/DirectedWeightedEdge_decl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class DirectedWeightedEdge : public DirectedEdge<T>, public Weighted {
6262
DirectedWeightedEdge(const DirectedEdge<T> &edge);
6363
DirectedWeightedEdge(const Edge<T> &edge);
6464
DirectedWeightedEdge(const UndirectedWeightedEdge<T> &edge);
65-
virtual ~DirectedWeightedEdge() = default;
65+
~DirectedWeightedEdge() override = default;
6666
const std::optional<bool> isWeighted() const override;
6767
// operator
6868
explicit operator UndirectedWeightedEdge<T>() const {

include/CXXGraph/Edge/UndirectedEdge_decl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class UndirectedEdge : public Edge<T> {
5151
const std::string &userId,
5252
const std::pair<shared<const Node<T>>, shared<const Node<T>>> &nodepair);
5353
UndirectedEdge(const Edge<T> &edge);
54-
virtual ~UndirectedEdge() = default;
54+
~UndirectedEdge() override = default;
5555
const Node<T> &getNode1() const;
5656
const Node<T> &getNode2() const;
5757
const std::optional<bool> isDirected() const override;

include/CXXGraph/Edge/UndirectedWeightedEdge_decl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ class UndirectedWeightedEdge : public UndirectedEdge<T>, public Weighted {
6464
UndirectedWeightedEdge(const UndirectedEdge<T> &edge);
6565
UndirectedWeightedEdge(const Edge<T> &edge);
6666
UndirectedWeightedEdge(const DirectedWeightedEdge<T> &edge);
67-
virtual ~UndirectedWeightedEdge() = default;
67+
~UndirectedWeightedEdge() override = default;
6868
const std::optional<bool> isWeighted() const override;
6969
// operator
7070
explicit operator DirectedWeightedEdge<T>() const {

include/CXXGraph/Partitioning/CoordinatedPartitionState.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class CoordinatedPartitionState : public PartitionState<T> {
6262
// DatWriter out; //to print the final partition of each edge
6363
public:
6464
CoordinatedPartitionState(const Globals &G);
65-
~CoordinatedPartitionState();
65+
~CoordinatedPartitionState() override;
6666

6767
std::shared_ptr<Record<T>> getRecord(CXXGraph::id_t x) override;
6868
int getMachineLoad(const int m) const override;

include/CXXGraph/Partitioning/CoordinatedRecord.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class CoordinatedRecord : public Record<T> {
3939

4040
public:
4141
CoordinatedRecord();
42-
~CoordinatedRecord();
42+
~CoordinatedRecord() override;
4343

4444
const std::set<int> &getPartitions() const override;
4545
void addPartition(const int m) override;

include/CXXGraph/Partitioning/EBV.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class EBV : public PartitionStrategy<T> {
5555

5656
public:
5757
explicit EBV(const Globals &G);
58-
~EBV();
58+
~EBV() override;
5959

6060
void performStep(shared<const Edge<T>> e,
6161
shared<PartitionState<T>> Sstate) override;

include/CXXGraph/Partitioning/EdgeBalancedVertexCut.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class EdgeBalancedVertexCut : public PartitionStrategy<T> {
5353

5454
public:
5555
explicit EdgeBalancedVertexCut(const Globals &G);
56-
~EdgeBalancedVertexCut();
56+
~EdgeBalancedVertexCut() override;
5757

5858
void performStep(shared<const Edge<T>> e,
5959
shared<PartitionState<T>> Sstate) override;

include/CXXGraph/Partitioning/GreedyVertexCut.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class GreedyVertexCut : public PartitionStrategy<T> {
5555

5656
public:
5757
explicit GreedyVertexCut(const Globals &G);
58-
~GreedyVertexCut();
58+
~GreedyVertexCut() override;
5959

6060
void performStep(shared<const Edge<T>> e,
6161
shared<PartitionState<T>> Sstate) override;

include/CXXGraph/Partitioning/HDRF.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class HDRF : public PartitionStrategy<T> {
5555

5656
public:
5757
explicit HDRF(const Globals &G);
58-
~HDRF();
58+
~HDRF() override;
5959

6060
void performStep(shared<const Edge<T>> e,
6161
shared<PartitionState<T>> Sstate) override;

0 commit comments

Comments
 (0)