Handle secret length in two cases.

Author: abdullahselek

authenticatorpy/authenticator.py

@@ -36,8 +36,12 @@ def __check_secret(self, secret):
             raise TypeError('You must set an ascii str variable as secret!')
         secret_without_spaces = self.remove_spaces(secret)
         self._secret = self.to_upper_case(secret_without_spaces)
-        if len(self._secret) % 8 != 0:
-            raise ValueError('You must set a string multiple of 8!')
+        secret_length = len(self._secret)
+        if secret_length < 8:
+            raise ValueError('You must set a secret of minimum 8 characters!')
+        if secret_length > 8:
+            index = secret_length % 8
+            self._secret = self._secret[:-index]
         if self.__is_alpha(self._secret) == False:
             raise TypeError('All characters in the secret must be alphabetic!')
 

tests/test_authenticator.py

@@ -21,7 +21,7 @@ def test_wrong_initiation(self):
         with self.assertRaises(Exception) as context:
             Authenticator('abcd')
 
-        self.assertTrue('You must set a string multiple of 8!' in str(context.exception))
+        self.assertTrue('You must set a secret of minimum 8 characters!' in str(context.exception))
 
         with self.assertRaises(Exception) as context:
             Authenticator(lambda: None)
@@ -81,9 +81,12 @@ def test_create_hmac(self):
     def test_one_time_password(self):
         password = self._authenticator.one_time_password()
         self.assertIsNotNone(password)
+        self.assertIsNotNone(Authenticator('abcd xyzw a').one_time_password())
+        self.assertIsNotNone(Authenticator('abcd xyzw ab').one_time_password())
+        self.assertIsNotNone(Authenticator('abcd xyzw abcd').one_time_password())
 
     def test_one_time_password_with_empty_spaces(self):
-        password = Authenticator('\t\t\t\t \t\t\t\t').one_time_password()
+        password = Authenticator('\ta\bt\tc\td \te\tf\tg\th').one_time_password()
         self.assertIsNotNone(password)
-        password = Authenticator('\r\r\r\r \r\r\r\r').one_time_password()
+        password = Authenticator('\ra\rb\rc\rd \re\rf\rg\rh').one_time_password()
         self.assertIsNotNone(password)