Properly throw an error, not a raw string

marijnh · marijnh · commit 7f67462af47a · 2025-11-14T10:03:06.000+01:00
Issue #1408
diff --git a/acorn-walk/src/index.js b/acorn-walk/src/index.js
@@ -180,10 +180,10 @@ export function make(funcs, baseVisitor) {
 }
 
 function skipThrough(node, st, c) { c(node, st) }
-function ignore(_node, _st, _c) { }
+function ignore(_node, _st, _c) {}
 
 function visitNode(baseVisitor, type, node, st, c) {
-  if (baseVisitor[type] == null) throw `No walker function defined for node type ${type}`
+  if (baseVisitor[type] == null) throw new Error(`No walker function defined for node type ${type}`)
   baseVisitor[type](node, st, c)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -180,10 +180,10 @@ export function make(funcs, baseVisitor) {`
`180`	`180`	`}`
`181`	`181`
`182`	`182`	`function skipThrough(node, st, c) { c(node, st) }`
`183`		`-function ignore(_node, _st, _c) { }`
	`183`	`+function ignore(_node, _st, _c) {}`
`184`	`184`
`185`	`185`	`function visitNode(baseVisitor, type, node, st, c) {`
`186`		- if (baseVisitor[type] == null) throw `No walker function defined for node type ${type}`
	`186`	+ if (baseVisitor[type] == null) throw new Error(`No walker function defined for node type ${type}`)
`187`	`187`	`baseVisitor[type](node, st, c)`
`188`	`188`	`}`
`189`	`189`