lint

Author: mertcanaltin

src/version_weaver.cpp

@@ -1,8 +1,9 @@
 #include "version_weaver.h"
+
 #include <algorithm>
 #include <cctype>
-#include <regex>
 #include <charconv>
+#include <regex>
 #include <sstream>
 namespace version_weaver {
 bool validate(std::string_view version) { return parse(version).has_value(); }
@@ -369,7 +370,9 @@ std::optional<std::string> minimum(std::string_view range) {
     }
   }
 
-  return bestCandidate;
+  if (validCandidates.empty()) return std::nullopt;
+  return *std::min_element(validCandidates.begin(), validCandidates.end(),
+                           compareSemVer);
 }
 
 std::expected<std::string, parse_error> inc(version input,
@@ -420,6 +423,14 @@ std::expected<std::string, parse_error> inc(version input,
   }
 }
 
+constexpr inline void trim_whitespace(std::string_view *input) noexcept {
+  while (!input->empty() && std::isspace(input->front())) {
+    input->remove_prefix(1);
+  }
+  while (!input->empty() && std::isspace(input->back())) {
+    input->remove_suffix(1);
+  }
+}
 
 constexpr inline bool contains_only_digits(std::string_view input) noexcept {
   // Optimization opportunity: Replace this with a hash table lookup.