-
Notifications
You must be signed in to change notification settings - Fork 1
feat: added minimum method #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
requested changes
Mar 3, 2025
anonrig
reviewed
Mar 4, 2025
Collaborator
Author
Member
|
@mertcanaltin Could you sync with the main branch? |
lemire
reviewed
Jul 15, 2025
f529f41 to
c370a4c
Compare
Member
|
@anonrig You have a requested change. |
f345199 to
76d227b
Compare
anonrig
approved these changes
Jul 16, 2025
Member
anonrig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code can be improved significantly but I'll not block if @lemire is ok
Member
|
We are far from a release. All the code will need to be re-review before we get to the first release. |
Member
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the minimum method and imported test cases from node-semver to ensure compatibility and correctness