Skip to content

Conversation

@mertcanaltin
Copy link
Collaborator

@mertcanaltin mertcanaltin commented Feb 21, 2025

I created the minimum method and imported test cases from node-semver to ensure compatibility and correctness

@mertcanaltin mertcanaltin changed the title feat: added minimum method [WİP]feat: added minimum method Mar 4, 2025
@mertcanaltin mertcanaltin requested a review from anonrig March 7, 2025 22:41
@mertcanaltin
Copy link
Collaborator Author

mertcanaltin commented Jul 15, 2025

I would be grateful if you could review it at your convenience ❤️ @anonrig @lemire

@lemire
Copy link
Member

lemire commented Jul 15, 2025

@mertcanaltin Could you sync with the main branch?

@mertcanaltin mertcanaltin force-pushed the mert/create-minimum branch from f529f41 to c370a4c Compare July 15, 2025 13:00
@lemire
Copy link
Member

lemire commented Jul 15, 2025

@anonrig You have a requested change.

@mertcanaltin mertcanaltin force-pushed the mert/create-minimum branch from f345199 to 76d227b Compare July 15, 2025 13:57
@mertcanaltin mertcanaltin changed the title [WİP]feat: added minimum method feat: added minimum method Jul 15, 2025
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code can be improved significantly but I'll not block if @lemire is ok

@lemire
Copy link
Member

lemire commented Jul 16, 2025

We are far from a release. All the code will need to be re-review before we get to the first release.

@lemire
Copy link
Member

lemire commented Jul 16, 2025

Merging.

@lemire lemire merged commit 12ad698 into main Jul 16, 2025
6 checks passed
@lemire lemire deleted the mert/create-minimum branch July 16, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants