Skip to content

Commit edf0532

Browse files
committed
Reinstate relative comparisons without quotes
Signed-off-by: Stewart X Addison <[email protected]>
1 parent 6f697f6 commit edf0532

File tree

2 files changed

+11
-16
lines changed

2 files changed

+11
-16
lines changed

ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/tasks/CentOS.yml

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,7 @@
3939
- name: Enable CodeReady Builder repo for CentOS9 Stream
4040
shell: dnf config-manager --set-enabled crb
4141
when:
42-
- ansible_distribution_major_version != "6"
43-
- ansible_distribution_major_version != "7"
44-
- ansible_distribution_major_version != "8"
42+
- ansible_distribution_major_version| int > 8
4543
tags: patch_update
4644

4745
- name: Clean dnf cache
@@ -75,33 +73,29 @@
7573
package: "name={{ item }} state=latest"
7674
with_items: "{{ Additional_Build_Tools_CentOS8_Plus }}"
7775
when:
78-
- ansible_distribution_major_version != "6"
79-
- ansible_distribution_major_version != "7"
76+
- ansible_distribution_major_version|int > 7
77+
- ansible_distribution_major_version|int > 7
8078
tags: build_tools
8179

8280
- name: Install additional build tools when NOT CentOS8+
8381
package: "name={{ item }} state=latest"
8482
with_items: "{{ Additional_Build_Tools_NOT_CentOS8_CentOS9Stream }}"
8583
when:
86-
- ansible_distribution_major_version != "6"
87-
- ansible_distribution_major_version != "7"
84+
- ansible_distribution_major_version|int < 8
8885
tags: build_tools
8986

9087
- name: Install additional test tools for CentOS 10+ e.g. weston
9188
package: "name={{ item }} state=latest"
9289
with_items: "{{ Additional_Test_Tools_CentOS10_Plus }}"
9390
when:
94-
- ansible_distribution_major_version != "6"
95-
- ansible_distribution_major_version != "7"
96-
- ansible_distribution_major_version != "8"
97-
- ansible_distribution_major_version != "9"
91+
- ansible_distribution_major_version|int > 10
9892
tags: test_tools
9993

10094
- name: Install additional tools for CentOS pre-10
10195
package: "name={{ item }} state=latest"
10296
with_items: "{{ Additional_Test_Tools_PreCentOS10 }}"
10397
when:
104-
- ansible_distribution_major_version != "10"
98+
- ansible_distribution_major_version|int < 10
10599
tags: test_tools
106100

107101
- name: Install libdwarf.h for CentOS8 Stream
@@ -324,8 +318,8 @@
324318
name: java
325319
path: "{{ jre_path.stat.lnk_source }}/bin/java"
326320
when:
327-
- ansible_distribution_major_version != "6"
328-
- ansible_distribution_major_version != "10"
321+
- ansible_distribution_major_version|int > 6
322+
- ansible_distribution_major_version|int < 10
329323
tags: default_java
330324

331325
- name: Set Default JDK (CentOS 6)
@@ -341,8 +335,8 @@
341335
name: javac
342336
path: "{{ jdk_path.stat.lnk_source }}/bin/javac"
343337
when:
344-
- ansible_distribution_major_version != "6"
345-
- ansible_distribution_major_version != "10"
338+
- ansible_distribution_major_version|int > 6
339+
- ansible_distribution_major_version|int < 10
346340
tags: default_java
347341

348342
###########

ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Common/vars/CentOS.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ Additional_Build_Tools_CentOS8_Plus:
8686
Additional_Build_Tools_NOT_CentOS8_CentOS9Stream:
8787
- lbzip2
8888
- java-1.7.0-openjdk-devel
89+
- java-1.8.0-openjdk-devel
8990
- ntp
9091

9192
Additional_Build_Tools_CentOS_x86:

0 commit comments

Comments
 (0)