"Skipped parameter" warnings in jenkins server log

[sxa]

These aren't new but were discovered while working on #2108

There are a lot of warnings in the jenkins log which we should look at clearing up in the interests of avoid the risk of being unable to see the wood for the trees. All are related to NODE_LABEL's use in various places.

Presumably the parameters are being passed in from the upstream job somewhere but they are not defined on the callee so are superfluous. Can we wasily stop 'rogue' parameters being passed in or should we set the -D mentioned in the error?

90 WARNING hudson.model.ParametersAction#filter: Skipped parameter NODE_LABEL as it is undefined on build-scripts/release/create_installer_mac. Set -Dhudson.model.ParametersAction.keepUndefinedParameters=true to allow undefined parameters to be injected as environment variables or -Dhudson.model.ParametersAction.safeParameters=[comma-separated list] to whitelist specific parameter names, even though it represents a security breach or -Dhudson.model.ParametersAction.keepUndefinedParameters=false to no longer show this message.

[sxa]

FYI @andrew-m-leonard @smlambert (Shelley I sent you a log from this a while back and I think there may be fewer such messages now but unclear if that's my memory or if it was a slightly different error!

[sxa]

Also tagging @sophia-guo since she was involved in the discussions on the community call earlier today :-)

[sophia-guo]

According to the discussion if jenkins jobs are triggered with undefined parameters there will be those warnings in jenkins server log? If that is the case those warnings can be avoided by re-generating aqa-tests or smoketests jobs triggered by upstream.

Initially when new features was added there was a period that aqa-tests or smoke tests jobs were triggered with undefined parameters. For example, USE_TESTENV_PROPERTIES, the reason is testJobTemplate was not updated accordingly as it didn't affect the functionalities. I have double checked all parameters of aqa-tests and smoke tests, all of them have been updated in testJobTemplate. That means if there is still those warning message related with aqa-tests or smoketests regenerating those jobs should fix it. Note autoGen is enabled with aqa-tests and disabled with smoketests.

[sxa]

Thanks for checking @sophia-guo! It looks like the remaining ones are mostly on the build pipelines so the test jobs may now be all sorted. I've just done a check on the recent logs and these are the remaining warnings - interestingly only the (new) jdk19u pipelines are showing up here @andrew-m-leonard:

jenkins@jenkins-hetzner-ubuntu2004:~$ gzip -cd /var/log/jenkins/jenkins.log.?.gz | grep Skipped.*undefined /var/log/jenkins/jenkins.log | sed -e 's/.*Skipped/Skipped/g' -e 's/. Set.*/./g' | sort | uniq -c
    282 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/jobs/jdk19u/jdk19u-aix-ppc64-temurin`.
    291 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/jobs/jdk19u/jdk19u-alpine-linux-aarch64-temurin`.
    306 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/jobs/jdk19u/jdk19u-alpine-linux-x64-temurin`.
    291 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/jobs/jdk19u/jdk19u-linux-aarch64-temurin`.
    286 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/jobs/jdk19u/jdk19u-linux-arm-temurin`.
    278 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/jobs/jdk19u/jdk19u-linux-ppc64le-temurin`.
    270 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/jobs/jdk19u/jdk19u-linux-s390x-temurin`.
    294 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/jobs/jdk19u/jdk19u-linux-x64-temurin`.
    485 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/jobs/jdk19u/jdk19u-mac-aarch64-temurin`.
    488 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/jobs/jdk19u/jdk19u-mac-x64-temurin`.
    432 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/jobs/jdk19u/jdk19u-windows-x64-temurin`.
    447 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/jobs/jdk19u/jdk19u-windows-x86-32-temurin`.
     36 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/release/create_installer_mac`.
     72 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/release/sign_installer`.
    240 Skipped parameter `NODE_LABEL` as it is undefined on `build-scripts/release/sign_temurin_gpg`.
jenkins@jenkins-hetzner-ubuntu2004:~$ 

[andrew-m-leonard]

@sxa I don't understand the above, none of the build jobs have a Parameter called NODE_LABEL, they only have 4 paramaters:

• BUILD_CONFIGURATION
• USER_REMOTE_CONFIGS
• DEFAULTS_JSON
• ADOPT_DEFAULTS_JSON

[sxa]

That sounds consistent with the warning message - "it is undefined on " but presumably something is trying to start them using those extra, unusable, parameters.