Skip to content

Conversation

@sxa
Copy link
Member

@sxa sxa commented Nov 26, 2025

This is the code that is being used by the test_image_updater job in support of adoptium/aqa-tests#5684

At the moment the job is running from my branch but the code is now in a reasonable state (it just doesn't have a full set of architectures) so I'm upstreaming this so that the job can be pointed at the upstream repository.

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

sxa and others added 11 commits September 3, 2025 12:38
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, but approving on the notion that updates can come later.

I am guessing you want it merged and then we can start changing the location from test-container to adoptium-test-images ? Or is now a good time to switch to that?

def dockerManifest() {
// dockerhub is the ID of the credentials stored in Jenkins
docker.withRegistry('https://ghcr.io', 'ghcr-adoptium') {
git poll: false, url: 'https://github.com/sxa/infrastructure.git'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you still wanting to reference sxa/infrastructure here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I'm pretty sure those aren't needed so I'll run a test with those two lines commented out.

def cosign() {
// dockerhub is the ID of the credentials stored in Jenkins
docker.withRegistry('https://ghcr.io', 'ghcr-adoptium') {
git poll: false, url: 'https://github.com/sxa/infrastructure.git'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another reference to sxa fork

@sxa
Copy link
Member Author

sxa commented Nov 27, 2025

Added a few comments, but approving on the notion that updates can come later.

I am guessing you want it merged and then we can start changing the location from test-container to adoptium-test-images ? Or is now a good time to switch to that?

I'd say keep that separate. I'd like the outcome from adoptium/containers#853 before making the change to use the newer repo.

@sxa sxa changed the title Test image Add pipeline code for test_image_updater job Nov 27, 2025
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good oto me

Signed-off-by: Stewart X Addison <[email protected]>
@sxa sxa merged commit 7a8bab1 into adoptium:master Nov 28, 2025
9 checks passed
@sxa
Copy link
Member Author

sxa commented Nov 28, 2025

Noting that https://ci.adoptium.net/job/test_image_updater/60/ ran through with the git poll of the infra repo removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants