-
-
Notifications
You must be signed in to change notification settings - Fork 102
Add pipeline code for test_image_updater job #4161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
smlambert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, but approving on the notion that updates can come later.
I am guessing you want it merged and then we can start changing the location from test-container to adoptium-test-images ? Or is now a good time to switch to that?
ansible/docker/Jenkinsfile.test
Outdated
| def dockerManifest() { | ||
| // dockerhub is the ID of the credentials stored in Jenkins | ||
| docker.withRegistry('https://ghcr.io', 'ghcr-adoptium') { | ||
| git poll: false, url: 'https://github.com/sxa/infrastructure.git' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you still wanting to reference sxa/infrastructure here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I'm pretty sure those aren't needed so I'll run a test with those two lines commented out.
ansible/docker/Jenkinsfile.test
Outdated
| def cosign() { | ||
| // dockerhub is the ID of the credentials stored in Jenkins | ||
| docker.withRegistry('https://ghcr.io', 'ghcr-adoptium') { | ||
| git poll: false, url: 'https://github.com/sxa/infrastructure.git' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another reference to sxa fork
I'd say keep that separate. I'd like the outcome from adoptium/containers#853 before making the change to use the newer repo. |
Signed-off-by: Stewart X Addison <[email protected]>
steelhead31
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good oto me
Signed-off-by: Stewart X Addison <[email protected]>
|
Noting that https://ci.adoptium.net/job/test_image_updater/60/ ran through with the |
This is the code that is being used by the test_image_updater job in support of adoptium/aqa-tests#5684
At the moment the job is running from my branch but the code is now in a reasonable state (it just doesn't have a full set of architectures) so I'm upstreaming this so that the job can be pointed at the upstream repository.
Checklist