Skip to content

Conversation

@tthailu
Copy link

@tthailu tthailu commented May 6, 2024

Adding should not filter to base interceptor.

Description

The PR above adds should not filter methods to the base interceptor.
It is provided in a way subclasses can override this method to control what requests should not be filtered.

changes in this Pull request

Added should not filter to

  1. synapse-api-rest-imperative BaseHttpInterceptor
  2. synapse-client-rest BaseHttpInterceptor

@tthailu tthailu marked this pull request as ready for review May 6, 2024 21:02
@tthailu tthailu requested a review from a team as a code owner May 6, 2024 21:02
@tthailu tthailu requested a review from sowmyab9 May 6, 2024 21:02
Copy link
Collaborator

@jmartinez5120 jmartinez5120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants