fix: update logging configs to ignore debug flag when given given a user provided logger

Author: kyeh-amp

src/amplitude_experiment/local/config.py

@@ -44,7 +44,7 @@ def __init__(self, debug: bool = False,
                 assignment_config (AssignmentConfig): The assignment configuration.
                 cohort_sync_config (CohortSyncConfig): The cohort sync configuration.
                 logger (logging.Logger): Optional logger instance. If provided, this logger will be used instead of
-                  creating a new one. The debug flag will still be applied to set the log level.
+                  creating a new one. The debug flag only applies when no logger is provided.
 
            Returns:
                The config object
@@ -76,10 +76,9 @@ def __init__(self, debug: bool = False,
             if not self.logger.handlers:
                 handler = logging.StreamHandler(sys.stderr)
                 self.logger.addHandler(handler)
+            # Set log level: DEBUG if debug=True, otherwise WARNING
+            # Only apply debug flag to default logger, not user-provided loggers
+            log_level = logging.DEBUG if self.debug else logging.WARNING
+            self.logger.setLevel(log_level)
         else:
             self.logger = logger
-        
-        # Set log level: DEBUG if debug=True, otherwise WARNING
-        # This applies to both provided loggers and the default logger
-        log_level = logging.DEBUG if self.debug else logging.WARNING
-        self.logger.setLevel(log_level)

src/amplitude_experiment/remote/config.py

@@ -31,7 +31,7 @@ def __init__(self, debug=False,
                 fetch_retry_backoff_scalar (float): Scales the minimum backoff exponentially.
                 fetch_retry_timeout_millis (int): The request timeout for retrying fetch requests.
                 logger (logging.Logger): Optional logger instance. If provided, this logger will be used instead of
-                  creating a new one. The debug flag will still be applied to set the log level.
+                  creating a new one. The debug flag only applies when no logger is provided.
 
             Returns:
                 The config object
@@ -52,10 +52,9 @@ def __init__(self, debug=False,
             if not self.logger.handlers:
                 handler = logging.StreamHandler(sys.stderr)
                 self.logger.addHandler(handler)
+            # Set log level: DEBUG if debug=True, otherwise WARNING
+            # Only apply debug flag to default logger, not user-provided loggers
+            log_level = logging.DEBUG if self.debug else logging.WARNING
+            self.logger.setLevel(log_level)
         else:
             self.logger = logger
-        
-        # Set log level: DEBUG if debug=True, otherwise WARNING
-        # This applies to both provided loggers and the default logger
-        log_level = logging.DEBUG if self.debug else logging.WARNING
-        self.logger.setLevel(log_level)

tests/local/config_test.py

@@ -41,25 +41,21 @@ def test_custom_logger_is_used(self):
         self.assertEqual(config.logger, custom_logger)
         self.assertEqual(config.logger.name, "CustomLogger")
 
-    def test_custom_logger_has_debug_level_when_debug_true(self):
-        """Test that custom logger has DEBUG level set when debug=True"""
-        custom_logger = logging.getLogger("CustomLogger")
-        config = LocalEvaluationConfig(debug=True, logger=custom_logger)
-        self.assertEqual(config.logger.level, logging.DEBUG)
-
-    def test_custom_logger_has_warning_level_when_debug_false(self):
-        """Test that custom logger has WARNING level set when debug=False"""
-        custom_logger = logging.getLogger("CustomLogger")
-        config = LocalEvaluationConfig(debug=False, logger=custom_logger)
-        self.assertEqual(config.logger.level, logging.WARNING)
-
-    def test_custom_logger_debug_flag_takes_precedence(self):
-        """Test that debug flag takes precedence over logger's existing level"""
-        custom_logger = logging.getLogger("CustomLogger")
+    def test_custom_logger_level_not_modified_by_debug_flag(self):
+        """Test that custom logger level is not modified by debug flag"""
+        # Test with debug=True
+        custom_logger = logging.getLogger("CustomLoggerDebug")
         custom_logger.setLevel(logging.ERROR)
         config = LocalEvaluationConfig(debug=True, logger=custom_logger)
-        # Debug flag should override to DEBUG
-        self.assertEqual(config.logger.level, logging.DEBUG)
+        # Logger level should remain unchanged (ERROR), not modified to DEBUG
+        self.assertEqual(config.logger.level, logging.ERROR)
+        
+        # Test with debug=False
+        custom_logger2 = logging.getLogger("CustomLoggerWarning")
+        custom_logger2.setLevel(logging.INFO)
+        config2 = LocalEvaluationConfig(debug=False, logger=custom_logger2)
+        # Logger level should remain unchanged (INFO), not modified to WARNING
+        self.assertEqual(config2.logger.level, logging.INFO)
 
     def test_default_logger_only_one_handler_added(self):
         """Test that only one handler is added to default logger"""

tests/remote/config_test.py

@@ -41,25 +41,21 @@ def test_custom_logger_is_used(self):
         self.assertEqual(config.logger, custom_logger)
         self.assertEqual(config.logger.name, "CustomLogger")
 
-    def test_custom_logger_has_debug_level_when_debug_true(self):
-        """Test that custom logger has DEBUG level set when debug=True"""
-        custom_logger = logging.getLogger("CustomLogger")
-        config = RemoteEvaluationConfig(debug=True, logger=custom_logger)
-        self.assertEqual(config.logger.level, logging.DEBUG)
-
-    def test_custom_logger_has_warning_level_when_debug_false(self):
-        """Test that custom logger has WARNING level set when debug=False"""
-        custom_logger = logging.getLogger("CustomLogger")
-        config = RemoteEvaluationConfig(debug=False, logger=custom_logger)
-        self.assertEqual(config.logger.level, logging.WARNING)
-
-    def test_custom_logger_debug_flag_takes_precedence(self):
-        """Test that debug flag takes precedence over logger's existing level"""
-        custom_logger = logging.getLogger("CustomLogger")
+    def test_custom_logger_level_not_modified_by_debug_flag(self):
+        """Test that custom logger level is not modified by debug flag"""
+        # Test with debug=True
+        custom_logger = logging.getLogger("CustomLoggerDebug")
         custom_logger.setLevel(logging.ERROR)
         config = RemoteEvaluationConfig(debug=True, logger=custom_logger)
-        # Debug flag should override to DEBUG
-        self.assertEqual(config.logger.level, logging.DEBUG)
+        # Logger level should remain unchanged (ERROR), not modified to DEBUG
+        self.assertEqual(config.logger.level, logging.ERROR)
+        
+        # Test with debug=False
+        custom_logger2 = logging.getLogger("CustomLoggerWarning")
+        custom_logger2.setLevel(logging.INFO)
+        config2 = RemoteEvaluationConfig(debug=False, logger=custom_logger2)
+        # Logger level should remain unchanged (INFO), not modified to WARNING
+        self.assertEqual(config2.logger.level, logging.INFO)
 
     def test_default_logger_only_one_handler_added(self):
         """Test that only one handler is added to default logger"""