♻️Rename to WithConversionFactorFrom/ToBase

Author: angularsen

UnitsNet.Tests/CustomCode/QuantityInfos/Builder/QuantityInfoBuilderExtensionsTest.cs

@@ -46,8 +46,8 @@ public void Configure_UpdatesSpecificUnit()
     public void WithConversionFromBase_CreatesNewDefinition()
     {
         UnitDefinition<LengthUnit> oldDefinition = Length.LengthInfo.GetDefaultMappings().First();
-        
-        UnitDefinition<LengthUnit> newDefinition = oldDefinition.WithConversionFromBase(20);
+
+        UnitDefinition<LengthUnit> newDefinition = oldDefinition.WithConversionFactorFromBase(20);
 
         Assert.Equal(oldDefinition.Value, newDefinition.Value);
         Assert.Equal(oldDefinition.Name, newDefinition.Name);
@@ -62,7 +62,7 @@ public void WithConversionToBase_CreatesNewDefinition()
     {
         UnitInfo<Length, LengthUnit> oldDefinition = Length.Info.BaseUnitInfo;
 
-        UnitDefinition<LengthUnit> newDefinition = oldDefinition.WithConversionToBase(20);
+        UnitDefinition<LengthUnit> newDefinition = oldDefinition.WithConversionFactorToBase(20);
 
         Assert.Equal(oldDefinition.Value, newDefinition.Value);
         Assert.Equal(oldDefinition.Name, newDefinition.Name);

UnitsNet.Tests/UnitConverterTest.cs

@@ -175,7 +175,7 @@ public void GetConversionFunction_WithCustomUnitConversion(bool freeze, Conversi
             bool reduceConstants)
         {
             var customLengthInfo = Length.LengthInfo.CreateDefault(unitDefinitions =>
-                unitDefinitions.Configure(LengthUnit.Inch, definition => definition.WithConversionFromBase(18)));
+                unitDefinitions.Configure(LengthUnit.Inch, definition => definition.WithConversionFactorFromBase(18)));
 
             var unitParser = new UnitParser([customLengthInfo]);
             var convertOptions = new QuantityConverterBuildOptions(freeze, cachingMode, reduceConstants);
@@ -219,7 +219,7 @@ public void GetConversionFunction_WithCustomUnitConversion(bool freeze, Conversi
         public void TryGetConversionFunction_WithCustomUnitConversion_ReturnsTrue(bool freeze, ConversionCachingMode cachingMode, bool reduceConstants)
         {
             var customLengthInfo = Length.LengthInfo.CreateDefault(unitDefinitions =>
-                unitDefinitions.Configure(LengthUnit.Inch, definition => definition.WithConversionFromBase(18)));
+                unitDefinitions.Configure(LengthUnit.Inch, definition => definition.WithConversionFactorFromBase(18)));
 
             var unitParser = new UnitParser([customLengthInfo]);
             var convertOptions = new QuantityConverterBuildOptions(freeze, cachingMode, reduceConstants);

UnitsNet/CustomCode/QuantityInfo/Builder/QuantityInfoBuilderExtensions.cs

@@ -79,7 +79,7 @@ public static IEnumerable<TUnitDefinition> Configure<TUnitDefinition, TUnit>(thi
     /// <param name="unitDefinition">The unit definition to which the conversion factor will be added.</param>
     /// <param name="conversionFromBase">The conversion factor from the base unit to the specified unit.</param>
     /// <returns>A new <see cref="UnitDefinition{TUnit}" /> instance with the specified conversion factor from the base unit.</returns>
-    public static UnitDefinition<TUnit> WithConversionFromBase<TUnit>(this IUnitDefinition<TUnit> unitDefinition, QuantityValue conversionFromBase)
+    public static UnitDefinition<TUnit> WithConversionFactorFromBase<TUnit>(this IUnitDefinition<TUnit> unitDefinition, QuantityValue conversionFromBase)
         where TUnit : struct, Enum
     {
         return new UnitDefinition<TUnit>(unitDefinition.Value, unitDefinition.Name, unitDefinition.PluralName, unitDefinition.BaseUnits, conversionFromBase);
@@ -92,7 +92,7 @@ public static UnitDefinition<TUnit> WithConversionFromBase<TUnit>(this IUnitDefi
     /// <param name="unitDefinition">The unit definition to which the conversion factor will be added.</param>
     /// <param name="conversionToBase">The conversion factor to the base unit from the specified unit.</param>
     /// <returns>A new <see cref="UnitDefinition{TUnit}" /> instance with the specified conversion factor to the base unit.</returns>
-    public static UnitDefinition<TUnit> WithConversionToBase<TUnit>(this IUnitDefinition<TUnit> unitDefinition, QuantityValue conversionToBase)
+    public static UnitDefinition<TUnit> WithConversionFactorToBase<TUnit>(this IUnitDefinition<TUnit> unitDefinition, QuantityValue conversionToBase)
         where TUnit : struct, Enum
     {
         return new UnitDefinition<TUnit>(unitDefinition.Value, unitDefinition.Name, unitDefinition.PluralName, unitDefinition.BaseUnits,