admission_control_policy cannot be disabled

[pandalec]

SUMMARY

admission_control_policy cannot be configured as disabled, like in vSphere GUI via vmware.vmware.cluster_ha

ISSUE TYPE

• Bug Report

COMPONENT NAME

vmware.vmware.cluster_ha

ANSIBLE VERSION

2.17.13

COLLECTION VERSION

2.3.0

STEPS TO REPRODUCE

    - name: Enable HA with disabled admission control policy
      vmware.vmware.cluster_ha:
        admission_control_policy: disabled
        cluster_name: "{{ vcenter_cluster }}"
        datacenter_name: "{{ vcenter_datacenter }}"
        enable: true
        hostname: "{{ vcenter_hostname }}"
        password: "{{ vcenter_password }}"
        username: "{{ vcenter_username }}"
        validate_certs: "{{ vcenter_validate_certs }}"

EXPECTED RESULTS

Enabled HA with disabled admission_control_policy

ACTUAL RESULTS

value of admission_control_policy must be one of: vm_slots, cluster_resource, dedicated_host, got: disabled

Default is set to dedicated_host which leads to error on single node clusters as there are no resources left for deploying virtual machines and there's no option to disable acp.

[mikemorency]

duplicate of #243. I am going to keep the newer one open, since there are more details and someone opened a pr

[mikemorency]

After some closer review, I think the linked issue is actually slightly different, so I am going to re-open this