what does "equals" do?

[darkship]

Hey,

I believe that this option does nothing.

it("optional equal - fastDeepEquals",function() {
		const optionalEqual = nanomemoize(function(a,b) { return [a,b]; },
		    {
			equals:()=> {
					throw new Error("never called")
				}}),
			[a1,a2] = optionalEqual({a:1}, {a:1}),
			values = optionalEqual.values();
		expect(fastDeepEqual(a1,a2)).to.equal(true);
		expect(values[0].length).to.equal(2);
		expect(fastDeepEqual(values[0][0],a1)).to.equal(true);
		expect(fastDeepEqual(values[0][1],a2)).to.equal(true);
	})

I tried to break the tests by throwing but the test is still green

[anywhichway]

Look at lines 46 thru 67 of index.js. is supposed to use the function you provide for testing arguments instead of the built in one. I will review code and test cases.

…

________________________________ From: Thomas ***@***.***> Sent: Thursday, November 16, 2023 12:02:12 PM To: anywhichway/nano-memoize ***@***.***> Cc: Subscribed ***@***.***> Subject: [anywhichway/nano-memoize] what does "equals" do? (Issue #66) Hey, I believe that this option does nothing. it("optional equal - fastDeepEquals",function() { const optionalEqual = nanomemoize(function(a,b) { return [a,b]; }, { equals:()=> { throw new Error("never called") }}), [a1,a2] = optionalEqual({a:1}, {a:1}), values = optionalEqual.values(); expect(fastDeepEqual(a1,a2)).to.equal(true); expect(values[0].length).to.equal(2); expect(fastDeepEqual(values[0][0],a1)).to.equal(true); expect(fastDeepEqual(values[0][1],a2)).to.equal(true); }) I tried to break the tests by throwing but the test is still green — Reply to this email directly, view it on GitHub<#66>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABF2US6ADLZ5RJPH6X3A6WTYEZWMJAVCNFSM6AAAAAA7OW33XGVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TONRWHE4DGMA>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>