Skip to content

Commit 7a4587c

Browse files
committed
Move out some exceptions to TaskSDK
As part of the ongoing server/client separation, this commit moves out some exceptions to the Task sdk. The AirflowException usage in task sdk has been changed to RuntimeError. Also, the TaskNotFound exception is still duplicated due to the many usages in core API and SDK.
1 parent c00f1d7 commit 7a4587c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+432
-398
lines changed

.pre-commit-config.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1656,10 +1656,12 @@ repos:
16561656
^airflow-core/src/airflow/api_fastapi/core_api/services/public/connections\.py$|
16571657
^airflow-core/src/airflow/api_fastapi/core_api/datamodels/hitl\.py$|
16581658
^airflow-core/src/airflow/api_fastapi/core_api/datamodels/variables\.py$|
1659+
^airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run\.py$|
16591660
^airflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid\.py$|
16601661
^airflow-core/src/airflow/api_fastapi/core_api/routes/ui/structure\.py$|
16611662
^airflow-core/src/airflow/api_fastapi/core_api/services/ui/connections\.py$|
16621663
^airflow-core/src/airflow/api_fastapi/core_api/services/ui/grid\.py$|
1664+
^airflow-core/src/airflow/api_fastapi/execution_api/routes/connections\.py$|
16631665
^airflow-core/src/airflow/api_fastapi/execution_api/routes/hitl\.py$|
16641666
^airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances\.py$|
16651667
^airflow-core/src/airflow/api_fastapi/logging/decorators\.py$|

airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,9 @@
7777
)
7878
from airflow.api_fastapi.core_api.services.public.dag_run import DagRunWaiter
7979
from airflow.api_fastapi.logging.decorators import action_logging
80-
from airflow.exceptions import ParamValidationError
8180
from airflow.listeners.listener import get_listener_manager
8281
from airflow.models import DagModel, DagRun
82+
from airflow.sdk.exceptions import ParamValidationError
8383
from airflow.utils.state import DagRunState
8484
from airflow.utils.types import DagRunTriggeredByType, DagRunType
8585

airflow-core/src/airflow/api_fastapi/execution_api/routes/connections.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323

2424
from airflow.api_fastapi.execution_api.datamodels.connection import ConnectionResponse
2525
from airflow.api_fastapi.execution_api.deps import JWTBearerDep
26-
from airflow.exceptions import AirflowNotFoundException
2726
from airflow.models.connection import Connection
27+
from airflow.sdk.exceptions import AirflowNotFoundException
2828

2929

3030
async def has_connection_access(

airflow-core/src/airflow/cli/commands/connection_command.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@
3232
from airflow.cli.simple_table import AirflowConsole
3333
from airflow.cli.utils import is_stdout, print_export_output
3434
from airflow.configuration import conf
35-
from airflow.exceptions import AirflowNotFoundException
3635
from airflow.models import Connection
3736
from airflow.providers_manager import ProvidersManager
37+
from airflow.sdk.exceptions import AirflowNotFoundException
3838
from airflow.secrets.local_filesystem import load_connections_dict
3939
from airflow.utils import cli as cli_utils, helpers, yaml
4040
from airflow.utils.cli import suppress_logs_and_warning

airflow-core/src/airflow/example_dags/example_skip_dag.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@
2424

2525
import pendulum
2626

27-
from airflow.exceptions import AirflowSkipException
2827
from airflow.providers.standard.operators.empty import EmptyOperator
2928
from airflow.sdk import DAG, BaseOperator
29+
from airflow.sdk.exceptions import AirflowSkipException
3030
from airflow.utils.trigger_rule import TriggerRule
3131

3232
if TYPE_CHECKING:

0 commit comments

Comments
 (0)