-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[Fix](exec) some error in condition cache because cache digest error #58115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34841 ms |
TPC-DS: Total hot run time: 188339 ms |
ClickBench: Total hot run time: 27.57 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BiteTheDDDDt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Problem Summary:
Condition cache malfunctions occurred due to flawed cache digest calculation in two core components, leading to inconsistent hash values, incorrect cache hits/misses, or query execution errors:
In VBloomPredicate::get_digest() (file: be/src/vec/exprs/vbloom_predicate.cpp), the digest was computed directly using bloom filter data without incorporating the child expression’s digest, omitting critical context for hash consistency.
In VRuntimeFilterWrapper::get_digest() (file: be/src/vec/exprs/vruntimefilter_wrapper.h), the _null_aware flag (a key attribute controlling filter behavior) was excluded from digest calculation, resulting in invalid cache key generation.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)