-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[check](column) add column self check #57909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34296 ms |
TPC-DS: Total hot run time: 187950 ms |
ClickBench: Total hot run time: 28.07 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
38e3a9a to
dc13ce6
Compare
|
run buildall |
TPC-H: Total hot run time: 34744 ms |
TPC-DS: Total hot run time: 188206 ms |
ClickBench: Total hot run time: 27.48 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run cloud_p0 |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dc13ce6 to
8814621
Compare
|
run buildall |
TPC-H: Total hot run time: 36008 ms |
TPC-DS: Total hot run time: 188751 ms |
ClickBench: Total hot run time: 27.82 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 34329 ms |
TPC-DS: Total hot run time: 188393 ms |
ClickBench: Total hot run time: 27.42 s |
…57995) ### What problem does this PR solve? This error can occur in this PR (#57909 ``` mysql> SELECT JSON_REMOVE('{"a": 1, "b": 2, "c": 3}', '\$.b'); ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INVALID_ARGUMENT]null map check failed for column: Const(Nullable(String)) ``` Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [x] No need to test or manual test. Explain why: - [x] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…57995) ### What problem does this PR solve? This error can occur in this PR (#57909 ``` mysql> SELECT JSON_REMOVE('{"a": 1, "b": 2, "c": 3}', '\$.b'); ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INVALID_ARGUMENT]null map check failed for column: Const(Nullable(String)) ``` Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [x] No need to test or manual test. Explain why: - [x] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run external |
|
run buildall |
TPC-H: Total hot run time: 34050 ms |
TPC-DS: Total hot run time: 187861 ms |
ClickBench: Total hot run time: 27.5 s |
|
run buildall |
TPC-H: Total hot run time: 34561 ms |
TPC-DS: Total hot run time: 185662 ms |
ClickBench: Total hot run time: 27.47 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run external |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
3fb67a6 to
af14472
Compare
|
run buildall |
TPC-H: Total hot run time: 35233 ms |
TPC-DS: Total hot run time: 188280 ms |
ClickBench: Total hot run time: 27.37 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 34273 ms |
TPC-DS: Total hot run time: 189046 ms |
ClickBench: Total hot run time: 27.43 s |
What problem does this PR solve?
A const column is not allowed to be nested; it may only appear as the outermost (top-level) column.
Only 0 and 1 are allowed in the nullmap.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)