Skip to content

Conversation

@renyuweighub
Copy link
Contributor

@renyuweighub renyuweighub commented Nov 20, 2025

Details: By moving the subscription logic after initializing referenceConfigurationListener in the dynamic configuration
Addresses: #15783

What is the purpose of the change?

What's the problem

In Dubbo 3.2.11 and all latest Dubbo 3 versions, the interface-level timeout and retry configurations become invalid after the caller application is restarted

Root cause

The investigation into why the referenceConfigurationListener was null points to a potential timing issue in the RegistryDirectory class's subscribe method: providers are being subscribed to before the referenceConfigurationListener is initialized.

How to fix

I solve this problem by placing the referenceConfigurationListener initialization logic before the call to super.subscribe(url).

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

…lid after the caller application is restarted

Details: By moving the subscription logic after initializing referenceConfigurationListener in the dynamic configuration
Addresses: apache#15783
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.75%. Comparing base (58d7386) to head (6e306d7).
⚠️ Report is 2 commits behind head on 3.3.

Files with missing lines Patch % Lines
.../dubbo/registry/integration/RegistryDirectory.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15784      +/-   ##
============================================
- Coverage     60.77%   60.75%   -0.02%     
+ Complexity    11706    11689      -17     
============================================
  Files          1938     1938              
  Lines         88646    88646              
  Branches      13379    13379              
============================================
- Hits          53875    53861      -14     
- Misses        29249    29258       +9     
- Partials       5522     5527       +5     
Flag Coverage Δ
integration-tests-java21 32.37% <83.33%> (+<0.01%) ⬆️
integration-tests-java8 32.39% <83.33%> (-0.05%) ⬇️
samples-tests-java21 32.06% <83.33%> (+0.07%) ⬆️
samples-tests-java8 29.68% <83.33%> (-0.05%) ⬇️
unit-tests-java11 59.07% <83.33%> (-0.03%) ⬇️
unit-tests-java17 58.56% <83.33%> (+<0.01%) ⬆️
unit-tests-java21 58.54% <83.33%> (+0.01%) ⬆️
unit-tests-java25 58.49% <83.33%> (-0.01%) ⬇️
unit-tests-java8 59.07% <83.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw changed the title Fix: the interface-level timeout and retry configurations become inva… Fix: the interface-level timeout and retry configurations become invalid after the caller application is restarted Nov 20, 2025
@zrlw zrlw self-requested a review November 20, 2025 07:50
Copy link
Contributor

@zrlw zrlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@RainYuY RainYuY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RainYuY RainYuY merged commit 21c2908 into apache:3.3 Nov 20, 2025
33 checks passed
@renyuweighub renyuweighub deleted the fix-issue-15783 branch November 20, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants