Skip to content

Commit 01cc865

Browse files
authored
MINOR: Correct ShareCoordinatorMetrics comments and sensor name constant (#20999)
1. The comment incorrectly referenced `write-latency-total`, but the actual metrics are `write-latency-max` (using Max() statistics). <img width="564" height="633" alt="image" src="https://github.com/user-attachments/assets/9b6b5e45-2060-453f-b7dd-49ada8c946b9" /> 2. The `SHARE_COORDINATOR_STATE_TOPIC_PRUNE_SENSOR_NAME` constant value had a redundant "SensorName" suffix that was inconsistent with other sensor name constants. Removing it ensures consistent naming conventions across all sensor name constants. Reviewers: Sushant Mahajan <[email protected]>, Andrew Schofield <[email protected]>
1 parent 889c3d4 commit 01cc865

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

share-coordinator/src/main/java/org/apache/kafka/coordinator/share/metrics/ShareCoordinatorMetrics.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,16 @@
3838
import java.util.concurrent.ConcurrentHashMap;
3939

4040
public class ShareCoordinatorMetrics extends CoordinatorMetrics implements AutoCloseable {
41-
//write (write-rate and write-total) Meter share-coordinator-metric The number of share-group state write calls per second.
42-
//write-latency (write-latency-avg and write-latency-total) Meter share-coordinator-metrics The time taken for a share-group state write call, including the time to write to the share-group state topic.
41+
// write (write-rate and write-total) Meter share-coordinator-metrics The number of share-group state write calls per second.
42+
// write-latency (write-latency-avg and write-latency-max) Meter share-coordinator-metrics The time taken for a share-group state write call, including the time to write to the share-group state topic.
4343
public static final String METRICS_GROUP = "share-coordinator-metrics";
4444

4545
private final Metrics metrics;
4646
private final Map<TopicPartition, ShareCoordinatorMetricsShard> shards = new ConcurrentHashMap<>();
4747

4848
public static final String SHARE_COORDINATOR_WRITE_SENSOR_NAME = "ShareCoordinatorWrite";
4949
public static final String SHARE_COORDINATOR_WRITE_LATENCY_SENSOR_NAME = "ShareCoordinatorWriteLatency";
50-
public static final String SHARE_COORDINATOR_STATE_TOPIC_PRUNE_SENSOR_NAME = "ShareCoordinatorStateTopicPruneSensorName";
50+
public static final String SHARE_COORDINATOR_STATE_TOPIC_PRUNE_SENSOR_NAME = "ShareCoordinatorStateTopicPrune";
5151
private final Map<TopicPartition, ShareGroupPruneMetrics> pruneMetrics = new ConcurrentHashMap<>();
5252

5353
/**

0 commit comments

Comments
 (0)