Skip to content

Commit 6b1f926

Browse files
authored
Merge branch 'master' into master
2 parents e8b6200 + 40e00a5 commit 6b1f926

File tree

4 files changed

+11
-15
lines changed

4 files changed

+11
-15
lines changed

oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/tcp/k8s/K8sALSServiceMeshTCPAnalysis.java

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020

2121
import com.google.common.base.Strings;
2222
import io.envoyproxy.envoy.config.core.v3.Address;
23-
import io.envoyproxy.envoy.config.core.v3.SocketAddress;
2423
import io.envoyproxy.envoy.data.accesslog.v3.AccessLogCommon;
2524
import io.envoyproxy.envoy.data.accesslog.v3.TCPAccessLogEntry;
2625
import io.envoyproxy.envoy.service.accesslog.v3.StreamAccessLogsMessage;
@@ -33,6 +32,7 @@
3332
import org.apache.skywalking.oap.server.receiver.envoy.als.Role;
3433
import org.apache.skywalking.oap.server.receiver.envoy.als.ServiceMetaInfo;
3534
import org.apache.skywalking.oap.server.receiver.envoy.als.istio.IstioServiceEntryRegistry;
35+
import org.apache.skywalking.oap.server.receiver.envoy.als.k8s.Addresses;
3636
import org.apache.skywalking.oap.server.receiver.envoy.als.k8s.K8SServiceRegistry;
3737
import org.apache.skywalking.oap.server.receiver.envoy.als.tcp.AbstractTCPAccessLogAnalyzer;
3838

@@ -101,9 +101,9 @@ protected Result analyzeSideCar(final Result previousResult, final TCPAccessLogE
101101
properties.hasDownstreamDirectRemoteAddress()
102102
? properties.getDownstreamDirectRemoteAddress()
103103
: properties.getDownstreamRemoteAddress();
104-
final ServiceMetaInfo downstreamService = find(downstreamRemoteAddress.getSocketAddress().getAddress());
104+
final ServiceMetaInfo downstreamService = find(Addresses.getAddressIP(downstreamRemoteAddress));
105105
final Address downstreamLocalAddress = properties.getDownstreamLocalAddress();
106-
final ServiceMetaInfo localService = find(downstreamLocalAddress.getSocketAddress().getAddress());
106+
final ServiceMetaInfo localService = find(Addresses.getAddressIP(downstreamLocalAddress));
107107

108108
if (cluster.startsWith("inbound|")) {
109109
// Server side
@@ -124,8 +124,7 @@ protected Result analyzeSideCar(final Result previousResult, final TCPAccessLogE
124124
newResult.hasDownstreamMetrics(true);
125125
} else if (cluster.startsWith("outbound|")) {
126126
// sidecar(client side) -> sidecar
127-
final Address upstreamRemoteAddress = properties.getUpstreamRemoteAddress();
128-
final ServiceMetaInfo destService = find(upstreamRemoteAddress.getSocketAddress().getAddress());
127+
final ServiceMetaInfo destService = find(Addresses.getAddressIP(properties.getUpstreamRemoteAddress()));
129128

130129
final TCPServiceMeshMetric metric = newAdapter(entry, downstreamService, destService).adaptToUpstreamMetrics().build();
131130

@@ -154,16 +153,14 @@ protected Result analyzeProxy(final Result previousResult, final TCPAccessLogEnt
154153
return previousResult;
155154
}
156155

157-
final var downstreamLocalAddressSocketAddress = downstreamLocalAddress.getSocketAddress();
158-
final var ingress = find(downstreamLocalAddressSocketAddress.getAddress());
156+
final var ingress = find(Addresses.getAddressIP(downstreamLocalAddress));
159157

160158
final var newResult = previousResult.toBuilder();
161159
final var previousMetrics = previousResult.getMetrics();
162160
final var metrics = previousMetrics.getTcpMetricsBuilder();
163161

164162
if (!previousResult.hasDownstreamMetrics()) {
165-
final SocketAddress downstreamRemoteAddressSocketAddress = downstreamRemoteAddress.getSocketAddress();
166-
final ServiceMetaInfo outside = find(downstreamRemoteAddressSocketAddress.getAddress());
163+
final ServiceMetaInfo outside = find(Addresses.getAddressIP(downstreamRemoteAddress));
167164

168165
final TCPServiceMeshMetric.Builder metric = newAdapter(entry, outside, ingress).adaptToDownstreamMetrics();
169166

@@ -173,8 +170,7 @@ protected Result analyzeProxy(final Result previousResult, final TCPAccessLogEnt
173170
}
174171

175172
if (!previousResult.hasUpstreamMetrics()) {
176-
final SocketAddress upstreamRemoteAddressSocketAddress = upstreamRemoteAddress.getSocketAddress();
177-
final ServiceMetaInfo targetService = find(upstreamRemoteAddressSocketAddress.getAddress());
173+
final ServiceMetaInfo targetService = find(Addresses.getAddressIP(upstreamRemoteAddress));
178174

179175
final TCPServiceMeshMetric.Builder outboundMetric =
180176
newAdapter(entry, ingress, targetService)

oap-server/server-starter/src/main/resources/ui-initialized-templates/banyandb/banyandb-root.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@
2929
"graph": {
3030
"fontColor": "theme",
3131
"backgroundColor": "theme",
32-
"content": "BanyanDB is a distributed time-series database with built-in self-monitoring for real-time tracking of system health, performance, and resource utilization.",
32+
"content": "Provide BanyanDB monitoring through OpenTelemetry's Prometheus Receiver",
3333
"fontSize": 14,
3434
"textAlign": "left",
35-
"url": "https://skywalking.apache.org/docs/main/next/en/setup/backend/backend-banyandb/"
35+
"url": "https://skywalking.apache.org/docs/main/next/en/banyandb/dashboards-banyandb/"
3636
}
3737
}
3838
],

oap-server/server-starter/src/main/resources/ui-initialized-templates/menu.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ menus:
259259
i18nKey: self_observability_satellite
260260
- title: BanyanDB Server
261261
layer: BANYANDB
262-
description: BanyanDB is a time-series database designed for observability data storage and analysis.
262+
description: Provide BanyanDB monitoring through OpenTelemetry's Prometheus Receiver.
263263
documentLink: https://skywalking.apache.org/docs/main/next/en/banyandb/dashboards-banyandb/
264264
i18nKey: self_observability_banyandb
265265
- title: SkyWalking Java Agent

0 commit comments

Comments
 (0)