Skip to content

Commit 85db81b

Browse files
committed
Update upstream Rollouts update script PR message
Signed-off-by: Jonathan West <[email protected]>
1 parent 4bb8010 commit 85db81b

File tree

1 file changed

+4
-2
lines changed
  • hack/upgrade-rollouts-script

1 file changed

+4
-2
lines changed

hack/upgrade-rollouts-script/main.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,10 @@ func main() {
115115

116116
bodyText += `
117117
Before merging this PR, ensure you check the Argo Rollouts change logs and release notes:
118-
- ensure there are no changes to the Argo Rollouts install YAML that we need to respond to with changes in the operator
119-
- ensure there are no backwards incompatible API/behaviour changes in the change logs`
118+
- Ensure there are no changes to the Argo Rollouts install YAML that we need to respond to with changes in the operator
119+
- You can do this by downloading the 'install.yaml' from both the previous version (for example, v1.7.1) and new version (for example, v1.7.2), and then comparing them using a tool like [Meld](https://gitlab.gnome.org/GNOME/meld) or diff.
120+
- If there are changes to resources like Deployments and Roles in the install.yaml between the two versions, this will likely require a corresponding code change within the operator. e.g. a new permission added to a Role would require a change to the Role creation code in the operator.
121+
- Ensure there are no backwards incompatible API/behaviour changes in the change logs`
120122

121123
// 4) Create PR if it doesn't exist
122124
if stdout, stderr, err := runCommandWithWorkDir(pathToGitHubRepo, "gh", "pr", "create",

0 commit comments

Comments
 (0)