Skip to content

chore: Fix typos #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Fix typos #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion curves/bls12_381/src/curves/g1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ impl SWCurveConfig for Config {
let encoding = EncodingFlags {
is_compressed: compress == ark_serialize::Compress::Yes,
is_infinity: item.is_zero(),
is_lexographically_largest: item.y > -item.y,
is_lexicographically_largest: item.y > -item.y,
};
let mut p = *item;
if encoding.is_infinity {
Expand Down
2 changes: 1 addition & 1 deletion curves/bls12_381/src/curves/g2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ impl SWCurveConfig for Config {
let encoding = EncodingFlags {
is_compressed: compress == ark_serialize::Compress::Yes,
is_infinity: item.is_zero(),
is_lexographically_largest: item.y > -item.y,
is_lexicographically_largest: item.y > -item.y,
};
let mut p = *item;
if encoding.is_infinity {
Expand Down
14 changes: 7 additions & 7 deletions curves/bls12_381/src/curves/util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ pub const G2_SERIALIZED_SIZE: usize = 96;
pub struct EncodingFlags {
pub is_compressed: bool,
pub is_infinity: bool,
pub is_lexographically_largest: bool,
pub is_lexicographically_largest: bool,
}

impl EncodingFlags {
Expand All @@ -22,16 +22,16 @@ impl EncodingFlags {

let is_compressed = compression_flag_set == 1;
let is_infinity = infinity_flag_set == 1;
let is_lexographically_largest = sort_flag_set == 1;
let is_lexicographically_largest = sort_flag_set == 1;

if is_lexographically_largest && (!is_compressed || is_infinity) {
if is_lexicographically_largest && (!is_compressed || is_infinity) {
return Err(SerializationError::InvalidData);
}

Ok(Self {
is_compressed,
is_infinity,
is_lexographically_largest,
is_lexicographically_largest,
})
}

Expand All @@ -45,7 +45,7 @@ impl EncodingFlags {
bytes[0] |= 1 << 6;
}

if self.is_compressed && !self.is_infinity && self.is_lexographically_largest {
if self.is_compressed && !self.is_infinity && self.is_lexicographically_largest {
bytes[0] |= 1 << 5;
}
}
Expand Down Expand Up @@ -130,7 +130,7 @@ pub(crate) fn read_g1_compressed<R: ark_serialize::Read>(
}

let x = deserialize_fq(x_bytes).ok_or(SerializationError::InvalidData)?;
let p = G1Affine::get_point_from_x_unchecked(x, flags.is_lexographically_largest)
let p = G1Affine::get_point_from_x_unchecked(x, flags.is_lexicographically_largest)
.ok_or(SerializationError::InvalidData)?;

Ok(p)
Expand Down Expand Up @@ -202,7 +202,7 @@ pub(crate) fn read_g2_compressed<R: ark_serialize::Read>(
let xc0 = deserialize_fq(xc0_bytes).ok_or(SerializationError::InvalidData)?;
let x = Fq2::new(xc0, xc1);

let p = G2Affine::get_point_from_x_unchecked(x, flags.is_lexographically_largest)
let p = G2Affine::get_point_from_x_unchecked(x, flags.is_lexicographically_largest)
.ok_or(SerializationError::InvalidData)?;

Ok(p)
Expand Down
4 changes: 2 additions & 2 deletions serialize/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,14 +268,14 @@ pub trait CanonicalSerializeHashExt: CanonicalSerialize {
fn hash<H: Digest>(&self) -> GenericArray<u8, <H as OutputSizeUser>::OutputSize> {
let mut hasher = H::new();
self.serialize_compressed(HashMarshaller(&mut hasher))
.expect("HashMarshaller::flush should be infaillible!");
.expect("HashMarshaller::flush should be infallible!");
hasher.finalize()
}

fn hash_uncompressed<H: Digest>(&self) -> GenericArray<u8, <H as OutputSizeUser>::OutputSize> {
let mut hasher = H::new();
self.serialize_uncompressed(HashMarshaller(&mut hasher))
.expect("HashMarshaller::flush should be infaillible!");
.expect("HashMarshaller::flush should be infallible!");
hasher.finalize()
}
}
Expand Down
Loading