Skip to content

Conversation

@Fibonacci747
Copy link

[concat] Use from_evaluations_vec to move the built Vec instead of cloning via from_evaluations_slice, eliminating one full-buffer copy.
[fix_variables] After folding, truncate to 1 << (nv - dim) and return with from_evaluations_vec to avoid cloning the sliced prefix.
[evaluate] Compute the scalar directly by folding over a temporary buffer (cloned once from evaluations) and return a[0], avoiding constructing a new DenseMultilinearExtension

@Fibonacci747 Fibonacci747 requested review from a team as code owners November 12, 2025 19:54
@Fibonacci747 Fibonacci747 requested review from mmagician, weikengchen and z-tech and removed request for a team November 12, 2025 19:54
@weikengchen
Copy link
Member

You make a good point: the a few copying is actually a bit bad. Will review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants