todo a couple more things

Author: AlexWaygood

crates/ty_python_semantic/resources/mdtest/final.md

@@ -474,7 +474,11 @@ class C(A):
         pass
 
     if coinflip():
-        def method2(self) -> None: ...  # error: [override-of-final-method]
+        def method2(self) -> None: ...  # TODO: should emit [override-of-final-method]
+    else:
+        def method2(self) -> None: ...  # TODO: should emit [override-of-final-method]
+
+    if coinflip():
         def method3(self) -> None: ...  # error: [override-of-final-method]
         def method4(self) -> None: ...  # error: [override-of-final-method]
 ```

crates/ty_python_semantic/resources/mdtest/snapshots/final.md_-_Tests_for_the_`@typi…_-_A_possibly-undefined…_(fc7b496fd1986deb).snap

@@ -62,9 +62,13 @@ mdtest path: crates/ty_python_semantic/resources/mdtest/final.md
 48 |         pass
 49 | 
 50 |     if coinflip():
-51 |         def method2(self) -> None: ...  # error: [override-of-final-method]
-52 |         def method3(self) -> None: ...  # error: [override-of-final-method]
-53 |         def method4(self) -> None: ...  # error: [override-of-final-method]
+51 |         def method2(self) -> None: ...  # TODO: should emit [override-of-final-method]
+52 |     else:
+53 |         def method2(self) -> None: ...  # TODO: should emit [override-of-final-method]
+54 | 
+55 |     if coinflip():
+56 |         def method3(self) -> None: ...  # error: [override-of-final-method]
+57 |         def method4(self) -> None: ...  # error: [override-of-final-method]
 ```
 
 # Diagnostics
@@ -251,50 +255,14 @@ note: This is an unsafe fix and may change runtime behavior
 
 ```
 
-```
-error[override-of-final-method]: Cannot override `A.method2`
-  --> src/mdtest_snippet.py:51:13
-   |
-50 |     if coinflip():
-51 |         def method2(self) -> None: ...  # error: [override-of-final-method]
-   |             ^^^^^^^ Overrides a definition from superclass `A`
-52 |         def method3(self) -> None: ...  # error: [override-of-final-method]
-53 |         def method4(self) -> None: ...  # error: [override-of-final-method]
-   |
-info: `A.method2` is decorated with `@final`, forbidding overrides
-  --> src/mdtest_snippet.py:16:9
-   |
-14 |         def method2(self) -> None: ...
-15 |     else:
-16 |         @final
-   |         ------
-17 |         def method2(self) -> None: ...
-   |             ------- `A.method2` defined here
-18 |
-19 |     if coinflip():
-   |
-help: Remove the override of `method2`
-info: rule `override-of-final-method` is enabled by default
-48 |         pass
-49 | 
-50 |     if coinflip():
-   -         def method2(self) -> None: ...  # error: [override-of-final-method]
-51 +           # error: [override-of-final-method]
-52 |         def method3(self) -> None: ...  # error: [override-of-final-method]
-53 |         def method4(self) -> None: ...  # error: [override-of-final-method]
-note: This is an unsafe fix and may change runtime behavior
-
-```
-
 ```
 error[override-of-final-method]: Cannot override `A.method3`
-  --> src/mdtest_snippet.py:52:13
+  --> src/mdtest_snippet.py:56:13
    |
-50 |     if coinflip():
-51 |         def method2(self) -> None: ...  # error: [override-of-final-method]
-52 |         def method3(self) -> None: ...  # error: [override-of-final-method]
+55 |     if coinflip():
+56 |         def method3(self) -> None: ...  # error: [override-of-final-method]
    |             ^^^^^^^ Overrides a definition from superclass `A`
-53 |         def method4(self) -> None: ...  # error: [override-of-final-method]
+57 |         def method4(self) -> None: ...  # error: [override-of-final-method]
    |
 info: `A.method3` is decorated with `@final`, forbidding overrides
   --> src/mdtest_snippet.py:20:9
@@ -309,23 +277,23 @@ info: `A.method3` is decorated with `@final`, forbidding overrides
    |
 help: Remove the override of `method3`
 info: rule `override-of-final-method` is enabled by default
-49 | 
-50 |     if coinflip():
-51 |         def method2(self) -> None: ...  # error: [override-of-final-method]
+53 |         def method2(self) -> None: ...  # TODO: should emit [override-of-final-method]
+54 | 
+55 |     if coinflip():
    -         def method3(self) -> None: ...  # error: [override-of-final-method]
-52 +           # error: [override-of-final-method]
-53 |         def method4(self) -> None: ...  # error: [override-of-final-method]
+56 +           # error: [override-of-final-method]
+57 |         def method4(self) -> None: ...  # error: [override-of-final-method]
 note: This is an unsafe fix and may change runtime behavior
 
 ```
 
 ```
 error[override-of-final-method]: Cannot override `A.method4`
-  --> src/mdtest_snippet.py:53:13
+  --> src/mdtest_snippet.py:57:13
    |
-51 |         def method2(self) -> None: ...  # error: [override-of-final-method]
-52 |         def method3(self) -> None: ...  # error: [override-of-final-method]
-53 |         def method4(self) -> None: ...  # error: [override-of-final-method]
+55 |     if coinflip():
+56 |         def method3(self) -> None: ...  # error: [override-of-final-method]
+57 |         def method4(self) -> None: ...  # error: [override-of-final-method]
    |             ^^^^^^^ Overrides a definition from superclass `A`
    |
 info: `A.method4` is decorated with `@final`, forbidding overrides
@@ -342,11 +310,11 @@ info: `A.method4` is decorated with `@final`, forbidding overrides
    |
 help: Remove the override of `method4`
 info: rule `override-of-final-method` is enabled by default
-50 |     if coinflip():
-51 |         def method2(self) -> None: ...  # error: [override-of-final-method]
-52 |         def method3(self) -> None: ...  # error: [override-of-final-method]
+54 | 
+55 |     if coinflip():
+56 |         def method3(self) -> None: ...  # error: [override-of-final-method]
    -         def method4(self) -> None: ...  # error: [override-of-final-method]
-53 +           # error: [override-of-final-method]
+57 +           # error: [override-of-final-method]
 note: This is an unsafe fix and may change runtime behavior
 
 ```