[ty] Add code action to ignore diagnostic on the current line #21595

MichaReiser · 2025-11-23T16:17:13Z

Summary

Add an LSP code action to suppress a diagnostic on the current line by inserting a new ty:ignore comment or extending the codes of an existing ty:ignore comment.

Skip existing ty: ignore comments with a reason.

Test Plan

This needs integration tests

Screen.Recording.2025-11-23.at.17.17.37.mov

astral-sh-bot · 2025-11-23T16:19:08Z

Diagnostic diff on typing conformance tests

No changes detected when running ty on typing conformance tests ✅

crates/ty_server/src/server/api/requests/code_action.rs

astral-sh-bot · 2025-11-23T16:20:54Z

`mypy_primer` results

Changes were detected when running on open source projects

pydantic (https://github.com/pydantic/pydantic)
- pydantic/fields.py:943:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, int | float | str | ... omitted 3 union elements] | ((dict[str, int | float | str | ... omitted 3 union elements], /) -> None) | None`
+ pydantic/fields.py:943:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, Divergent] | ((dict[str, Divergent], /) -> None) | None`
- pydantic/fields.py:983:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, int | float | str | ... omitted 3 union elements] | ((dict[str, int | float | str | ... omitted 3 union elements], /) -> None) | None`
+ pydantic/fields.py:983:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, Divergent] | ((dict[str, Divergent], /) -> None) | None`
- pydantic/fields.py:1026:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, int | float | str | ... omitted 3 union elements] | ((dict[str, int | float | str | ... omitted 3 union elements], /) -> None) | None`
+ pydantic/fields.py:1026:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, Divergent] | ((dict[str, Divergent], /) -> None) | None`
- pydantic/fields.py:1066:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, int | float | str | ... omitted 3 union elements] | ((dict[str, int | float | str | ... omitted 3 union elements], /) -> None) | None`
+ pydantic/fields.py:1066:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, Divergent] | ((dict[str, Divergent], /) -> None) | None`
- pydantic/fields.py:1109:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, int | float | str | ... omitted 3 union elements] | ((dict[str, int | float | str | ... omitted 3 union elements], /) -> None) | None`
+ pydantic/fields.py:1109:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, Divergent] | ((dict[str, Divergent], /) -> None) | None`
- pydantic/fields.py:1148:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, int | float | str | ... omitted 3 union elements] | ((dict[str, int | float | str | ... omitted 3 union elements], /) -> None) | None`
+ pydantic/fields.py:1148:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, Divergent] | ((dict[str, Divergent], /) -> None) | None`
- pydantic/fields.py:1188:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, int | float | str | ... omitted 3 union elements] | ((dict[str, int | float | str | ... omitted 3 union elements], /) -> None) | None`
+ pydantic/fields.py:1188:5: error[invalid-parameter-default] Default value of type `PydanticUndefinedType` is not assignable to annotated parameter type `dict[str, Divergent] | ((dict[str, Divergent], /) -> None) | None`
- pydantic/fields.py:1567:13: error[invalid-argument-type] Argument is incorrect: Expected `dict[str, int | float | str | ... omitted 3 union elements] | ((dict[str, int | float | str | ... omitted 3 union elements], /) -> None) | None`, found `Top[dict[Unknown, Unknown]] | (((dict[str, int | float | str | ... omitted 3 union elements], /) -> None) & ~Top[dict[Unknown, Unknown]]) | None`
+ pydantic/fields.py:1567:13: error[invalid-argument-type] Argument is incorrect: Expected `dict[str, Divergent] | ((dict[str, Divergent], /) -> None) | None`, found `Top[dict[Unknown, Unknown]] | (((dict[str, Divergent], /) -> None) & ~Top[dict[Unknown, Unknown]]) | None`

No memory usage changes detected ✅

astral-sh-bot · 2025-11-28T17:22:42Z

`ruff-ecosystem` results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

MichaReiser · 2025-11-28T21:04:09Z

.config/nextest.toml

-[[profile.default.overrides]]
-filter = 'binary(e2e)'
-test-group = 'serial'
-


I think this is no longer needed, since I increased the request wait limit in e2e tests.

…ations

MichaReiser · 2025-11-28T21:30:41Z

crates/ty_python_semantic/resources/mdtest/suppressions/type_ignore.md

  + 2  # type: ignore
 ```

+## Interpolated strings


I didn't change the behavior for interpolated strings but I wrote this mdtest to document it, because it wasn't entirely clear to me when working on the fix.

Gankra · 2025-11-28T21:36:43Z

crates/ty_ide/src/code_action.rs

+        2 |             b = f"""
+        3 |                 {
+          -                 a
+        4 +                 a  # ty:ignore[unresolved-reference]
+        5 |                 }
+        6 |                 more text
+        7 |             """
+        "#);


Absolutely wild that this is valid syntax

Gankra · 2025-11-28T21:39:01Z

crates/ty_ide/src/code_action.rs

+        assert_snapshot!(test.code_actions(&UNRESOLVED_REFERENCE), @r"
+        info[code-action]: Ignore 'unresolved-reference' for this line
+         --> main.py:2:17
+          |
+        2 |             b = a / 0  # ty:ignore[division-by-zero] some explanation
+          |                 ^
+          |
+        1 | 
+          -             b = a / 0  # ty:ignore[division-by-zero] some explanation
+        2 +             b = a / 0  # ty:ignore[division-by-zero] some explanation  # ty:ignore[unresolved-reference]
+        3 |
+        ");


Terrified of ever working on ruff

MichaReiser added server Related to the LSP server ty Multi-file analysis & type inference labels Nov 23, 2025

MichaReiser commented Nov 23, 2025

View reviewed changes

crates/ty_server/src/server/api/requests/code_action.rs Outdated Show resolved Hide resolved

MichaReiser force-pushed the micha/add-ignore-action branch 2 times, most recently from b2cc26b to 7efe928 Compare November 25, 2025 10:59

Base automatically changed from micha/add-ignore-action to main November 25, 2025 13:08

MichaReiser force-pushed the micha/add-ty-ignore branch from 09ed5f7 to 517770c Compare November 28, 2025 17:04

MichaReiser force-pushed the micha/add-ty-ignore branch from 6b9d27a to 52f3c3e Compare November 28, 2025 17:38

MichaReiser commented Nov 28, 2025

View reviewed changes

MichaReiser force-pushed the micha/add-ty-ignore branch from 9d5de3a to f519d8a Compare November 28, 2025 21:13

MichaReiser added 5 commits November 28, 2025 22:19

[ty] Add code action to suppress diagnostic on current line

61911b8

Discard changes to crates/ty_server/src/server/api/diagnostics.rs

197bba4

Nit

f3f8cb2

Add code actions testing infrastructure

6818e03

More tests, handle multiline strings, line continuation, and interpol…

1fe5c19

…ations

MichaReiser force-pushed the micha/add-ty-ignore branch from f519d8a to 1fe5c19 Compare November 28, 2025 21:22

MichaReiser mentioned this pull request Nov 28, 2025

Non deterministic diagnostics astral-sh/ty#1670

Open

MichaReiser marked this pull request as ready for review November 28, 2025 21:29

MichaReiser requested review from AlexWaygood, carljm, dcreager and sharkdp as code owners November 28, 2025 21:29

MichaReiser requested review from Gankra and removed request for carljm, dcreager and sharkdp November 28, 2025 21:30

MichaReiser commented Nov 28, 2025

View reviewed changes

Gankra approved these changes Nov 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ty] Add code action to ignore diagnostic on the current line #21595

[ty] Add code action to ignore diagnostic on the current line #21595

MichaReiser commented Nov 23, 2025 •

edited

Loading

Uh oh!

astral-sh-bot bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

astral-sh-bot bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

astral-sh-bot bot commented Nov 28, 2025 •

edited

Loading

Uh oh!

MichaReiser Nov 28, 2025

Uh oh!

MichaReiser Nov 28, 2025

Uh oh!

Gankra Nov 28, 2025

Uh oh!

Gankra Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[ty] Add code action to ignore diagnostic on the current line #21595

Are you sure you want to change the base?

[ty] Add code action to ignore diagnostic on the current line #21595

Conversation

MichaReiser commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

astral-sh-bot bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Diagnostic diff on typing conformance tests

Uh oh!

Uh oh!

astral-sh-bot bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

mypy_primer results

Uh oh!

astral-sh-bot bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ruff-ecosystem results

Linter (stable)

Linter (preview)

Uh oh!

MichaReiser Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

MichaReiser Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Gankra Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Gankra Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MichaReiser commented Nov 23, 2025 •

edited

Loading

astral-sh-bot bot commented Nov 23, 2025 •

edited

Loading

astral-sh-bot bot commented Nov 23, 2025 •

edited

Loading

`mypy_primer` results

astral-sh-bot bot commented Nov 28, 2025 •

edited

Loading

`ruff-ecosystem` results