[ty] Preserve quoting style when autofixing TypedDict keys
#21682
+42
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
ty
AlexWaygood
requested review from
carljm,
dcreager and
sharkdp
as code owners
Gankra
approved these changes
Nov 28, 2025
Contributor
Gankra
left a comment
Gankra
left a comment
There was a problem hiding this comment.
We've unlocked a wonderful rat's nest of syntax
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
Member
Author
|
I'll add |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've been away from Ruff for too long -- I forgot how complicated writing autofixes can be 🙃
This is a minor followup to #21667 to make the
TypedDictfix introduced in that PR a bit better. It now preserves the quoting style of the previous string-literal node.Test Plan
added a snapshot