[ty] WIP: accelerate fixed-point convergence of recursively defined literal types #21683
+138
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
CodSpeed Performance ReportMerging #21683 will degrade performances by 9.91%Comparing Summary
Benchmarks breakdown
Footnotes
|
Contributor
Author
|
Hmm, for example, when inspecting the following code, I see a clear performance improvement locally, but the change on codspeed seems less clear: class Counter:
def __init__(self: "Counter"):
self.count = 0
def increment(self: "Counter"):
self.count = self.count + 1
reveal_type(Counter().count) # revealed: Unknown | intmain: # release
$ hyperfine -i "ty check widen.py"
Benchmark 1: ty check widen.py
Time (mean ± σ): 103.3 ms ± 8.6 ms [User: 56.9 ms, System: 45.0 ms]
Range (min … max): 96.4 ms … 136.6 ms 22 runs
# debug
$ hyperfine -i "ty check widen.py"
Benchmark 1: ty check widen.py
Time (mean ± σ): 899.9 ms ± 6.2 ms [User: 849.7 ms, System: 51.9 ms]
Range (min … max): 889.4 ms … 910.3 ms 10 runs# release
$ hyperfine -i "ty check widen.py"
Benchmark 1: ty check widen.py
Time (mean ± σ): 59.6 ms ± 9.2 ms [User: 26.5 ms, System: 37.8 ms]
Range (min … max): 52.5 ms … 95.7 ms 31 runs
# debug
$ hyperfine -i "ty check widen.py"
Benchmark 1: ty check widen.py
Time (mean ± σ): 267.2 ms ± 4.1 ms [User: 222.2 ms, System: 55.6 ms]
Range (min … max): 261.6 ms … 276.5 ms 10 runs |
Contributor
Author
|
Conversely, the apparent performance degradation is due to increasing The performance impact of changing 190: https://codspeed.io/astral-sh/ruff/runs/compare/6929edd91e804897641888e6..6929fa9ed77b771deb1a9244 |
…e performance diff" This reverts commit 961c578.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes astral-sh/ty#957
As explained in astral-sh/ty#957, literal union types for recursively defined values can be widened early to speed up the convergence of fixed-point iterations.
This PR achieves this by embedding a marker in
UnionTypethat distinguishes whether a value is recursively defined.This also allows us to identify values that are not recursively defined, so I've increased the limit on the number of elements in a literal union type for such values.
Test Plan
call/union.mdhas been updated