Merge pull request #1090 from atom/as/fix-test-flakiness

Try fixing flaky tests in results-view-spec.js

Author: Antonio Scandurra

spec/results-view-spec.js

@@ -668,6 +668,8 @@ describe('ResultsView', () => {
 
   describe("copying path with find-and-replace:copy-path", () => {
     it("copies the selected file path to clipboard", async () => {
+      jasmine.useRealClock()
+
       projectFindView.findEditor.setText('items');
       atom.commands.dispatch(projectFindView.element, 'core:confirm');
       await searchPromise;
@@ -685,28 +687,30 @@ describe('ResultsView', () => {
     });
 
     it("copies the selected file path to the clipboard when there are multiple project folders", async () => {
-        const folder1 = temp.mkdirSync('folder-1')
-        const file1 = path.join(folder1, 'sample.txt')
-        fs.writeFileSync(file1, 'items')
+      jasmine.useRealClock()
 
-        const folder2 = temp.mkdirSync('folder-2')
-        const file2 = path.join(folder2, 'sample.txt')
-        fs.writeFileSync(file2, 'items')
+      const folder1 = temp.mkdirSync('folder-1')
+      const file1 = path.join(folder1, 'sample.txt')
+      fs.writeFileSync(file1, 'items')
 
-        atom.project.setPaths([folder1, folder2]);
-        projectFindView.findEditor.setText('items');
-        atom.commands.dispatch(projectFindView.element, 'core:confirm');
-        await searchPromise;
+      const folder2 = temp.mkdirSync('folder-2')
+      const file2 = path.join(folder2, 'sample.txt')
+      fs.writeFileSync(file2, 'items')
 
-        resultsView = getResultsView();
-        await resultsView.heightInvalidationPromise;
-        resultsView.selectFirstResult();
-        resultsView.collapseResult();
-        atom.commands.dispatch(resultsView.element, 'find-and-replace:copy-path');
-        expect(atom.clipboard.read()).toBe(path.join(path.basename(folder1), path.basename(file1)));
-        atom.commands.dispatch(resultsView.element, 'core:move-down');
-        atom.commands.dispatch(resultsView.element, 'find-and-replace:copy-path');
-        expect(atom.clipboard.read()).toBe(path.join(path.basename(folder2), path.basename(file2)));
+      atom.project.setPaths([folder1, folder2]);
+      projectFindView.findEditor.setText('items');
+      atom.commands.dispatch(projectFindView.element, 'core:confirm');
+      await searchPromise;
+
+      resultsView = getResultsView();
+      await resultsView.heightInvalidationPromise;
+      resultsView.selectFirstResult();
+      resultsView.collapseResult();
+      atom.commands.dispatch(resultsView.element, 'find-and-replace:copy-path');
+      expect(atom.clipboard.read()).toBe(path.join(path.basename(folder1), path.basename(file1)));
+      atom.commands.dispatch(resultsView.element, 'core:move-down');
+      atom.commands.dispatch(resultsView.element, 'find-and-replace:copy-path');
+      expect(atom.clipboard.read()).toBe(path.join(path.basename(folder2), path.basename(file2)));
     });
   });