fix: enable -Wcast-qual flag for libcrypto=awslc (#4735)

Co-authored-by: Boquan Fang <[email protected]>
Co-authored-by: James Mayclin <[email protected]>

Author: 3 people

CMakeLists.txt

@@ -135,6 +135,7 @@ target_compile_options(${PROJECT_NAME} PRIVATE
     -std=gnu99
     -Wall
     -Wcast-align
+    -Wcast-qual
     -Wchar-subscripts
     -Wcomment
     -Wformat-security
@@ -232,11 +233,6 @@ endif()
 
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")
 
-if (NOT $ENV{S2N_LIBCRYPTO} MATCHES "awslc")
-    # add cast-qual back in for non AWS-LC
-    target_compile_options(${PROJECT_NAME} PRIVATE -Wcast-qual)
-endif()
-
 if (COVERAGE)
     # https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER_ID.html
     # Coverage is done using LLVM source based coverage. This is only supported