Skip to content

Conversation

@Yemaneberhan-Lemma
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for axelerant-engg-handbook ready!

Name Link
🔨 Latest commit 4af4c21
🔍 Latest deploy log https://app.netlify.com/sites/axelerant-engg-handbook/deploys/66c8e530e01e0b0008dde27a
😎 Deploy Preview https://deploy-preview-210--axelerant-engg-handbook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@hussainweb hussainweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yemaneberhan-Lemma, it's good that you found this action but there are multiple things wrong with the workflow. The most important thing is that it should have thrown an error for the existing broken links we know that exists, but the workflow passed. This is enough of a red flag.

Please check the workflow output for errors and see why it didn't cause the PR to fail. Also, the configuration won't catch all errors because you are running it before Hugo (why?). Running it before Hugo means that Lychee can't resolve the <relref> tags we heavily use (but Hugo would catch those anyway, so not a dealbreaker).

And then see the old action versions you are using. They are also throwing warnings in the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants