Skip to content

Commit 9a44c42

Browse files
fixing tests and imports
1 parent fe5b015 commit 9a44c42

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

src/axolotl/utils/schemas/validation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -759,7 +759,7 @@ def check_muon_deepspeed_fsdp(cls, data):
759759
if data.get("fsdp") or data.get("fsdp_config"):
760760
fsdp_version = data.get("fsdp_version")
761761
if fsdp_version is None:
762-
fsdp_version = fsdp_config.get("fsdp_version", 1)
762+
fsdp_version = data.get("fsdp_config", {}).get("fsdp_version", 1)
763763
if str(fsdp_version) != "2":
764764
raise ValueError(
765765
"Muon optimizer is only compatible with FSDP2. Set fsdp_version: 2 to use Muon with FSDP."

tests/core/test_builders.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -474,10 +474,7 @@ def test_custom_optimizer_cls_and_kwargs(
474474

475475
assert trainer.optimizer_cls_and_kwargs is not None
476476

477-
from axolotl.contribs.mit.muon import (
478-
Muon,
479-
MuonOptimizerFactory,
480-
)
477+
from axolotl.contribs.mit.muon import MuonOptimizerFactory
481478

482479
optimizer_cls, optimizer_kwargs = trainer.optimizer_cls_and_kwargs
483480
assert optimizer_cls is MuonOptimizerFactory
@@ -556,10 +553,7 @@ def test_custom_optimizer_cls_and_kwargs(
556553

557554
assert trainer.optimizer_cls_and_kwargs is not None
558555

559-
from axolotl.contribs.mit.muon import (
560-
Muon,
561-
MuonOptimizerFactory,
562-
)
556+
from axolotl.contribs.mit.muon import MuonOptimizerFactory
563557

564558
optimizer_cls, optimizer_kwargs = trainer.optimizer_cls_and_kwargs
565559
assert optimizer_cls is MuonOptimizerFactory

0 commit comments

Comments
 (0)