Make PHPStan happy

Author: nyamsprod

composer.json

@@ -28,11 +28,11 @@
   },
   "require-dev": {
     "friendsofphp/php-cs-fixer": "^v3.15.1",
-    "phpstan/phpstan": "^1.10.47",
+    "phpstan/phpstan": "^1.10.48",
     "phpstan/phpstan-strict-rules": "^1.5.2",
     "phpstan/phpstan-phpunit": "^1.3.15",
     "phpstan/phpstan-deprecation-rules": "^1.1.4",
-    "phpunit/phpunit": "^10.5.1",
+    "phpunit/phpunit": "^10.5.2",
     "symfony/var-dumper": "^6.4.0"
   },
   "autoload": {

src/Enum/Hasser.php

@@ -45,12 +45,8 @@ public static function hasName(string $name): bool
      */
     public static function hasValue(int|string $value): bool
     {
-        if (!(new ReflectionEnum(static::class))->isBacked()) {
-            return false;
-        }
-
         foreach (static::cases() as $enum) {
-            if ($enum->value === $value) { /* @phpstan-ignore-line */
+            if ($enum?->value === $value) { /* @phpstan-ignore-line */
                 return true;
             }
         }
@@ -65,12 +61,8 @@ public static function hasValue(int|string $value): bool
      */
     public static function hasCase(string $name, int|string $value): bool
     {
-        if (!(new ReflectionEnum(static::class))->isBacked()) {
-            return false;
-        }
-
         foreach (static::cases() as $enum) {
-            if ($enum->name === $name && $enum->value === $value) { /* @phpstan-ignore-line */
+            if ($enum?->name === $name && $enum?->value === $value) { /* @phpstan-ignore-line */
                 return true;
             }
         }

src/Enum/Info.php

@@ -14,7 +14,7 @@ trait Info
 {
     public static function isBacked(): bool
     {
-        return (new ReflectionEnum(static::class))->isBacked();
+        return (new ReflectionEnum(static::class))->isBacked(); /* @phpstan-ignore-line */
     }
 
     public static function isNotBacked(): bool

src/Error/CloakTest.php

@@ -82,7 +82,7 @@ public function testErrorTransformedIntoARuntimeException(): void
         $touch('/foo');
     }
 
-    public function testErrorTransformedIntoAnInvalidArgumentException(): void
+    public function testErrorTransformedIntoAnErrorException(): void
     {
         Cloak::throwOnError();
         $this->expectException(ErrorException::class);
@@ -96,14 +96,14 @@ public function testSpecificBehaviourOverrideGeneralErrorSetting(): void
         $this->expectNotToPerformAssertions();
 
         Cloak::throwOnError();
-        $touch = Cloak::userDeprecated(touch(...), Cloak::SILENT);
+        $touch = Cloak::warning(touch(...), Cloak::SILENT);
         $touch('/foo');
     }
 
     public function testCaptureNothingThrowNoException(): void
     {
         Cloak::throwOnError();
-        $strtoupper = Cloak::notice(strtoupper(...));
+        $strtoupper = Cloak::userDeprecated(strtoupper(...));
 
         self::assertSame('FOO', $strtoupper('foo'));
     }