-
Notifications
You must be signed in to change notification settings - Fork 4
workflows: re-enable finalise on push for generic-amd64-fs #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Changelog-entry: workflows: re-enable finalise on push for generic-amd64-fs Signed-off-by: Ryan Cooke <[email protected]>
|
One or more environments require approval before deploying workflow runs. Maintainers, please inspect changes carefully for improper handling of secrets or other sensitive information. To approve pending deployments, submit an approved review, or a commented review with |
| sign-image: true | ||
| signing-environment: sign.balena-cloud.com+generic-amd64-fs | ||
| # FIXME: Disable finalize-on-push until we have a test to verify that SIGN_KMOD_KEY_APPEND is set | ||
| finalize-on-push-if-tests-passed: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do the same for studio-automatedx86-sb while we are here? Though neither of them have tests defined.
klutchell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/deploy
|
@rcooke-warwick do we have a test for the signing key now? How come are we enabling this? |
Changelog-entry: workflows: re-enable finalise on push for generic-amd64-fs