Skip to content

Conversation

@rcooke-warwick
Copy link
Contributor

Changelog-entry: workflows: re-enable finalise on push for generic-amd64-fs

Changelog-entry: workflows: re-enable finalise on push for generic-amd64-fs
Signed-off-by: Ryan Cooke <[email protected]>
@deploynaut
Copy link

deploynaut bot commented Mar 17, 2025

One or more environments require approval before deploying workflow runs.

Maintainers, please inspect changes carefully for improper handling of secrets or other sensitive information.

To approve pending deployments, submit an approved review, or a commented review with /deploy.

@rcooke-warwick rcooke-warwick temporarily deployed to sign.balena-cloud.com March 17, 2025 12:19 — with GitHub Actions Inactive
@rcooke-warwick rcooke-warwick temporarily deployed to sign.balena-cloud.com+generic-amd64-fs March 17, 2025 12:19 — with GitHub Actions Inactive
@flowzone-app flowzone-app bot enabled auto-merge March 17, 2025 12:22
sign-image: true
signing-environment: sign.balena-cloud.com+generic-amd64-fs
# FIXME: Disable finalize-on-push until we have a test to verify that SIGN_KMOD_KEY_APPEND is set
finalize-on-push-if-tests-passed: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the same for studio-automatedx86-sb while we are here? Though neither of them have tests defined.

Copy link
Contributor

@klutchell klutchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/deploy

@floion
Copy link
Contributor

floion commented Aug 21, 2025

@rcooke-warwick do we have a test for the signing key now? How come are we enabling this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants