Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

Assertion doesn't handle failed check #89

@dhalperi

Description

@dhalperi

The questions underlying Batfish assertions can fail, in which case the Answer returned will not be a TableAnswer. In at least one case, the check is not handling this case well: instead of getting the error, we get:

fatal: [localhost]: FAILED! => {"changed": false, "msg": "1 of 1 assertions failed", "result": [{"details": "'Answer' object has no attribute 'frame'", "name": "Confirm routers can ping each other", "status": "Error", "type": "assert_all_flows_succeed"}], "summary": "1 of 1 assertions failed"}

(see: https://networktocode.slack.com/archives/CCE02JK7T/p1582840013048800)

Batfish should always check the answer type before calling .frame().

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions