Skip to content

Commit 8de8325

Browse files
committed
Disable media remoting by default
Chromecast is crippled in upstream UC, so media remoting can be safely disabled. We can remove enable_media_remoting_rpc=false from debian/rules, as this will automatically become false when enable_media_remoting is set to false. There is an unmerged pull request which enables chromecast [1], which I will implement in a subsequent commit. However I will keep the media remoting configuration option so that it can be disabled independently of chromecast. [1] ungoogled-software/ungoogled-chromium#2116
1 parent 78a14b9 commit 8de8325

14 files changed

+17
-17
lines changed

configure-variables.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ DRIVER 1 Chromedriver package
7878
CLICK_TO_CALL 1 Feature for using chromium to make a call via an android phone
7979
EXT_TOOLS_MENU 1 Move the extensions menu to the 'More tools' menu
8080
FEED 1 WebFeed (News feed) support
81-
MEDIA_REMOTING 1 Render and play back media on remote devices when a tab is casted
81+
MEDIA_REMOTING 0 Render and play back media on remote devices when a tab is casted
8282
MUTEX_PI 1 Mutex priority inheritance
8383
NOTIFICATIONS 1 System notifications
8484
OPENTYPE_SVG 1 Opentype SVG support

debian/configure.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ sanitise_op () {
7474
[ -n "$DRIVER" ] || DRIVER=1
7575
[ -n "$EXT_TOOLS_MENU" ] || EXT_TOOLS_MENU=1
7676
[ -n "$FEED" ] || FEED=1
77-
[ -n "$MEDIA_REMOTING" ] || MEDIA_REMOTING=1
77+
[ -n "$MEDIA_REMOTING" ] || MEDIA_REMOTING=0
7878
[ -n "$MUTEX_PI" ] || MUTEX_PI=1
7979
[ -n "$NOTIFICATIONS" ] || NOTIFICATIONS=1
8080
[ -n "$OAUTH2" ] || OAUTH2=0
@@ -610,11 +610,11 @@ if [ $FEED -eq 0 ]; then
610610
fi
611611

612612

613-
if [ $MEDIA_REMOTING -eq 0 ]; then
614-
op_enable="$op_enable disable/media-remoting"
613+
if [ $MEDIA_REMOTING -eq 1 ]; then
614+
op_disable="$op_disable disable/media-remoting/"
615615

616-
#GN_FLAGS += enable_media_remoting=false enable_media_remoting_rpc=false
617-
gn_enable="$gn_enable enable_media_remoting"
616+
#GN_FLAGS += enable_media_remoting=false
617+
gn_disable="$gn_disable enable_media_remoting"
618618
fi
619619

620620

debian/patches/series.debian

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,14 @@ vanadinite/0004-disable-article-suggestions-feature-by-default.patch
5252
vanadinite/0005-disable-content-feed-suggestions-by-default.patch
5353
vanadinite/0006-disable-sensors-access-by-default.patch
5454
vanadinite/0007-disable-background-sync-by-default.patch
55-
vanadinite/0008-disable-media-router-media-remoting-by-default.patch
56-
vanadinite/0009-disable-media-router-by-default.patch
57-
vanadinite/0010-disable-media-DRM-preprovisioning-by-default.patch
58-
vanadinite/0011-enable-split-cache-by-default.patch
59-
vanadinite/0012-enable-partitioning-connections-by-default.patch
60-
vanadinite/0013-disable-component-updater-pings-by-default.patch
61-
vanadinite/0014-Enable-strict-origin-isolation-by-default.patch
62-
vanadinite/0015-enable-process-isolated-sandboxed-iframes-by-default.patch
63-
vanadinite/0016-enable-partitioning-third-party-storage.patch
55+
vanadinite/0008-disable-media-router-by-default.patch
56+
vanadinite/0009-disable-media-DRM-preprovisioning-by-default.patch
57+
vanadinite/0010-enable-split-cache-by-default.patch
58+
vanadinite/0011-enable-partitioning-connections-by-default.patch
59+
vanadinite/0012-disable-component-updater-pings-by-default.patch
60+
vanadinite/0013-Enable-strict-origin-isolation-by-default.patch
61+
vanadinite/0014-enable-process-isolated-sandboxed-iframes-by-default.patch
62+
vanadinite/0015-enable-partitioning-third-party-storage.patch
6463

6564
various/compiler-flags/Do-not-link-with-libatomic.patch
6665
various/compiler-flags/function-import-limits.patch
@@ -124,8 +123,9 @@ optional/cpu/avx.patch
124123
#optional/disable/catapult.patch
125124
#optional/disable/click-to-call.patch
126125
optional/disable/dns_config_service.patch
127-
#optional/disable/media-remoting.patch
128126
optional/disable/supervised-users.patch
127+
optional/disable/media-remoting/media-remoting.patch
128+
optional/disable/media-remoting/registry-pref.patch
129129
#optional/fixes/convertutf-bundled.patch
130130
#optional/fixes/dav1d-bundled-header.patch
131131
optional/fixes/extensions-in-tools-menu.patch

0 commit comments

Comments
 (0)