fix(scripts): fix download-env-vars
#6048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskfla
commented
Jan 14, 2025
Comment on lines
-75
to
+78
| has_example_env_in_package=$(find $DIR/../../packages/$PACKAGE -type f -name '*.env.example' | wc -l) | ||
| if [ $has_example_env_in_package -eq 1 ]; then | ||
| load_env_file_from_bw $PACKAGE $DIR/../../packages/$PACKAGE "" | ||
| for PACKAGE in "${PACKAGES[@]}"; do | ||
| # Only download the env file if there is an example file in the package. If there isn’t, this | ||
| # means it is a package that doesn’t need env vars | ||
| if [[ -f $REPO_ROOT/packages/$PACKAGE/.env.example ]]; then |
Contributor
Author
There was a problem hiding this comment.
Much more direct way of checking for existence of a file, and saves spinning up a child process for find
Could also have been [[ ]] && load_env_file..., but the if is a bit more explicit
tcaiger
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that the
downloadEnvironmentVariables.shscript wasn’t working. #5568 previously made modifications to the script (though hasn't been merged)I used that as a starting point to fix up the script