fix(datatrak): RN-1490: survey response export containing User question

[jaskfla]

RN-1490 issue 5

[gemini-code-assist]

Summary of Changes

Hello @jaskfla, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where survey response exports did not correctly display answers for questions of type User. It introduces specific logic to extract and show the user's name for these questions, ensuring accurate data representation in exports. Additionally, it includes minor styling adjustments and type safety enhancements within the ExportSurveyResponsePage component.

Highlights

• User Question Display Fix: Implemented logic to correctly display the name for User type questions within survey response exports, resolving an issue where these answers were not properly rendered.
• Styling Refinement: Updated the QuestionWrapper styled component to use the border-block-end CSS property for consistent border styling and removed the conditional $border prop, simplifying the component's styling logic.
• Type Safety Improvement: Added an explicit React.ReactNode return type annotation to the useDisplayAnswer hook, enhancing type checking and code maintainability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[jaskfla]

Catch this type of error at build time instead

[gemini-code-assist]

Code Review

This pull request adds support for the User question type in the survey response export. The changes are well-contained within the Question.tsx component. My review includes a couple of suggestions to improve code robustness and maintainability, particularly around styling and data access patterns.

[jaskfla]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no bugs!

---

[cursor]

Bug: User Answer Fallback Needs Consistency

The QuestionType.User case assumes the answer has a name property but doesn't handle cases where it might be missing or undefined. If the UserAnswer object exists but lacks a name property, the function returns undefined instead of a fallback like other question types. Consider adding a fallback to answer itself or <em>No answer</em> when name is nullish.

 

[chris-bes]

lgtm