ci: clone coldcard repo only once

Co-Authored-By: GPT-5 (Preview) <[email protected]>

Author: Sjors

.github/workflows/ci.yml

@@ -119,9 +119,13 @@ jobs:
       # Trezor T binaries don't need this.
       runs-on: ubuntu-22.04
 
+  coldcard-firmware-seed:
+    uses: ./.github/workflows/coldcard-firmware-seed.yml
+
+  # Use the generic sim-builder with a Coldcard seed dependency
   sim-builder-coldcard:
     name: Coldcard sim builder
-    needs: prepare-sim-matrices
+    needs: [prepare-sim-matrices, coldcard-firmware-seed]
     uses: ./.github/workflows/sim-builder.yml
     with:
       sim: coldcard

.github/workflows/coldcard-firmware-seed.yml

@@ -0,0 +1,25 @@
+name: Coldcard Firmware Seed
+on:
+  workflow_call:
+
+jobs:
+  seed:
+    name: Seed Coldcard firmware (once per run)
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Clone Coldcard firmware (with submodules)
+        shell: bash
+        run: |
+          set -euo pipefail
+          mkdir -p test/work
+          pushd test/work
+            git clone --recursive https://github.com/Coldcard/firmware.git
+          popd
+
+      - name: Upload seeded repo as artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: coldcard-firmware-src
+          path: test/work/firmware

.github/workflows/sim-builder.yml

@@ -23,6 +23,15 @@ jobs:
         include: ${{ fromJSON(inputs.include) }}
     steps:
       - uses: actions/checkout@v4
+
+      # Coldcard: download seeded firmware (seed job must run earlier)
+      - name: Download seeded Coldcard firmware
+        if: ${{ inputs.sim == 'coldcard' }}
+        uses: actions/download-artifact@v4
+        with:
+          name: coldcard-firmware-src
+          path: test/work/firmware
+
       - uses: ./.github/actions/build-sim
         with:
           name: ${{ matrix.name }}

test/setup_environment.sh

@@ -149,14 +149,15 @@ if [[ -n ${build_coldcard} ]]; then
             coldcard_setup_needed=true
         fi
     fi
-    # Apply patch to make simulator work in linux environments
-    git am ../../data/coldcard-multisig.patch
 
     # Build the simulator. This is cached, but it is also fast
     poetry run pip install -r requirements.txt
     pip install -r requirements.txt
     cd unix
     if [ "$coldcard_setup_needed" == true ] ; then
+        # Apply patch to make simulator work in linux environments
+        git am ../../../data/coldcard-multisig.patch
+
         pushd ../external/micropython/mpy-cross/
         make
         popd