changed executeCommands to return array to force ordering

Author: bitsofinfo

processProxy.js

@@ -461,9 +461,8 @@ ProcessProxy.prototype.executeCommand = function(command) {
 
         .then(function(cmdResults) {
 
-            for (var cmd in cmdResults) {
-                fulfill(cmdResults[cmd]);
-            }
+            fulfill(cmdResults[0]);
+
 
         }).catch(function(error) {
             reject(error);
@@ -475,14 +474,16 @@ ProcessProxy.prototype.executeCommand = function(command) {
 
 /**
 * executeCommands - takes an array of raw command strings and returns promise
-*                  to be fulfilled with a a hash
-*                  of "command" -> {command:cmd, stdout:xxxx, stderr:xxxxx}
+*                  to be fulfilled with a an array of
+*                  of [
+*                       {command:cmd1, stdout:xxxx, stderr:xxxxx},
+*                       {command:cmd2, stdout:xxxx, stderr:xxxxx}
+*                     ]
 *
 * @commands Array of raw command/shell statements to be executed
 *
 * @return Promise, on fulfill returns promise to be fulfilled with a
-*                  hash of commands -> {stdout:xxxx, stderr:xxxxx}
-*                  on reject returns an exception
+*                  array of command results as described above
 *
 **/
 ProcessProxy.prototype.executeCommands = function(commands) {
@@ -493,7 +494,7 @@ ProcessProxy.prototype.executeCommands = function(commands) {
 
         try {
 
-            var cmdResults = new Object();
+            var cmdResults = [];
 
             for (var i = 0; i < commands.length; i++) {
 
@@ -505,13 +506,13 @@ ProcessProxy.prototype.executeCommands = function(commands) {
                     new Command(command,
                         function(cmd, stdout, stderr) {
 
-                            cmdResults[cmd] = {
-                                'command': cmd,
-                                'stdout': stdout,
-                                'stderr': stderr
-                            };
+                            cmdResults.push({
+                                  'command': cmd,
+                                  'stdout': stdout,
+                                  'stderr': stderr
+                              });
 
-                            if (Object.keys(cmdResults).length == commands.length) {
+                            if (cmdResults.length == commands.length) {
                                 fulfill(cmdResults);
                             }
 

statefulProcessCommandProxy.js

@@ -133,8 +133,8 @@ function StatefulProcessCommandProxy(config) {
                     delete self._pid2processMap[processProxy.getPid()];
 
                     if (cmdResults) {
-                        for (var cmd in cmdResults) {
-                            var cmdResult = cmdResults[cmd];
+                        for (var i=0; i<cmdResults.length; i++) {
+                            var cmdResult = cmdResults[i];
                             self._log('info',"process preDestroyCmd[" +
                             cmdResult.command + "] out:" + cmdResult.stdout +
                                 " err:" + cmdResult.stderr);
@@ -280,14 +280,17 @@ StatefulProcessCommandProxy.prototype.executeCommand = function(command) {
 
 /**
 * executeCommand - takes an array of raw command strings and returns promise
-*                  to be fulfilled with a a hash
-*                  of "command" -> {command:cmd, stdout:xxxx, stderr:xxxxx}
+*                  to be fulfilled with an array of cmdResults
+*                  [
+*                    {command:cmd1, stdout:xxxx, stderr:xxxxx},
+*                    {command:cmd2, stdout:xxxx, stderr:xxxxx}
+*                  ]
+*
 *
 * @commands Array of raw command/shell statements to be executed
 *
 * @return Promise, on fulfill returns promise to be fulfilled with a
-*                  hash of commands -> {stdout:xxxx, stderr:xxxxx}
-*                  on reject returns an exception
+*                  array of cmdResults
 *
 **/
 StatefulProcessCommandProxy.prototype.executeCommands = function(commands) {

test/all.js

@@ -71,7 +71,7 @@ describe('test stateful-process-command-proxy', function() {
                 max: 1,
                 min: 1,
                 idleTimeoutMillis: 10000,
-                
+
                 logFunction: function(severity,origin,msg) {
                     console.log(severity.toUpperCase() + " " +origin+" "+ msg);
                 },
@@ -116,10 +116,10 @@ describe('test stateful-process-command-proxy', function() {
             // assert all commands, lookup the command
             // via the result, to get its asserter
             // then invoke the asserter passing the cmd result
-            for (var key in cmdResults) {
-                var command = cmdResults[key].command;
+            for (var i=0; i<cmdResults.length; i++) {
+                var command = cmdResults[i].command;
                 var asserter = config.testCommands[command];
-                asserter(cmdResults[key]);
+                asserter(cmdResults[i]);
             }
 
             // collect status