Merge pull request #97 from blas-lapack-rs/get-from-web

Download OpenBLAS source code from GitHub Release in build.rs

Author: termoshtt

openblas-build/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "openblas-build"
-version = "0.10.5"
+version = "0.10.6"
 license = "Apache-2.0/MIT"
 edition = "2018"
 authors = [
@@ -16,5 +16,9 @@ exclude = [
 ]
 
 [dependencies]
+anyhow = "1.0.68"
+flate2 = "1.0.25"
+tar = "0.4.38"
 thiserror = "1.0.22"
+ureq = "2.5.0"
 walkdir = "2.3.1"

openblas-build/src/build.rs

@@ -1,13 +1,7 @@
 //! Execute make of OpenBLAS, and its options
 
 use crate::{check::*, error::*};
-use std::{
-    fs,
-    os::unix::io::*,
-    path::*,
-    process::{Command, Stdio},
-    str::FromStr,
-};
+use std::{fs, path::*, process::Command, str::FromStr};
 use walkdir::WalkDir;
 
 /// Interface for 32-bit interger (LP64) and 64-bit integer (ILP64)
@@ -397,8 +391,8 @@ impl Configure {
         let err = fs::File::create(out_dir.join("err.log")).expect("Cannot create log file");
         match Command::new("make")
             .current_dir(out_dir)
-            .stdout(unsafe { Stdio::from_raw_fd(out.into_raw_fd()) }) // this works only for unix
-            .stderr(unsafe { Stdio::from_raw_fd(err.into_raw_fd()) })
+            .stdout(out)
+            .stderr(err)
             .args(&self.make_args())
             .args(["libs", "netlib", "shared"])
             .env_remove("TARGET")
@@ -436,17 +430,7 @@ mod tests {
 
     fn get_openblas_source() -> PathBuf {
         let openblas_src_root = PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("../openblas-src");
-        let openblas_version = "0.3.21";
-        let source = openblas_src_root.join(format!("OpenBLAS-{}", openblas_version));
-        if !source.exists() {
-            Command::new("tar")
-                .arg("xf")
-                .arg(format!("OpenBLAS-{}.tar.gz", openblas_version))
-                .current_dir(openblas_src_root)
-                .status()
-                .expect("tar command not found");
-        }
-        source
+        crate::download(&openblas_src_root).unwrap()
     }
 
     #[ignore]

openblas-build/src/download.rs

@@ -0,0 +1,23 @@
+use anyhow::Result;
+use std::path::{Path, PathBuf};
+
+const OPENBLAS_VERSION: &str = "0.3.21";
+
+pub fn openblas_source_url() -> String {
+    format!(
+        "https://github.com/xianyi/OpenBLAS/releases/download/v{}/OpenBLAS-{}.tar.gz",
+        OPENBLAS_VERSION, OPENBLAS_VERSION
+    )
+}
+
+pub fn download(out_dir: &Path) -> Result<PathBuf> {
+    let dest = out_dir.join(format!("OpenBLAS-{}", OPENBLAS_VERSION));
+    if !dest.exists() {
+        let buf = ureq::get(&openblas_source_url()).call()?.into_reader();
+        let gz_stream = flate2::read::GzDecoder::new(buf);
+        let mut ar = tar::Archive::new(gz_stream);
+        ar.unpack(out_dir)?;
+        assert!(dest.exists());
+    }
+    Ok(dest)
+}

openblas-build/src/lib.rs

@@ -14,6 +14,8 @@
 
 mod build;
 mod check;
+mod download;
 pub mod error;
 pub use build::*;
 pub use check::*;
+pub use download::*;

openblas-src/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "openblas-src"
-version = "0.10.5"
+version = "0.10.6"
 license = "Apache-2.0/MIT"
 edition = "2018"
 authors = [
@@ -37,10 +37,7 @@ libc = "0.2"
 
 [build-dependencies]
 dirs = "3.0.1"
+openblas-build = { version = "0.10.6", path = "../openblas-build" }
 
 [target.'cfg(target_os="windows")'.build-dependencies]
 vcpkg = "0.2"
-
-[target.'cfg(target_os="linux")'.build-dependencies.openblas-build]
-version = "0.10.5"
-path = "../openblas-build"

openblas-src/OpenBLAS-0.3.21.tar.gz

@@ -1,6 +1,19 @@
 use std::{env, path::*, process::Command};
 
-const OPENBLAS_VERSION: &str = "0.3.21";
+#[allow(unused)]
+fn run(command: &mut Command) {
+    println!("Running: `{:?}`", command);
+    match command.status() {
+        Ok(status) => {
+            if !status.success() {
+                panic!("Failed: `{:?}` ({})", command, status);
+            }
+        }
+        Err(error) => {
+            panic!("Failed: `{:?}` ({})", command, error);
+        }
+    }
+}
 
 fn feature_enabled(feature: &str) -> bool {
     env::var(format!("CARGO_FEATURE_{}", feature.to_uppercase())).is_ok()
@@ -160,17 +173,8 @@ fn build() {
         );
     }
 
-    let source = output.join(format!("OpenBLAS-{}", OPENBLAS_VERSION));
-    if !source.exists() {
-        let crate_root = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
-        Command::new("tar")
-            .arg("xf")
-            .arg(crate_root.join(format!("OpenBLAS-{}.tar.gz", OPENBLAS_VERSION)))
-            .current_dir(&output)
-            .status()
-            .expect("tar command not found");
-    }
-    let deliv = cfg.build(&source, &output).unwrap();
+    let source = openblas_build::download(&output).unwrap();
+    let deliv = cfg.build(source, &output).unwrap();
 
     println!("cargo:rustc-link-search={}", output.display());
     for search_path in &deliv.make_conf.c_extra_libs.search_paths {
@@ -240,17 +244,7 @@ fn build() {
     };
 
     if !source.exists() {
-        let source_tmp = PathBuf::from(format!("{}_tmp", source.display()));
-        if source_tmp.exists() {
-            fs::remove_dir_all(&source_tmp).unwrap();
-        }
-        run(Command::new("tar")
-            .arg("xf")
-            .arg(format!("OpenBLAS-{}.tar.gz", OPENBLAS_VERSION)));
-        run(Command::new("cp")
-            .arg("-R")
-            .arg(format!("OpenBLAS-{}", OPENBLAS_VERSION))
-            .arg(&source_tmp));
+        let source_tmp = openblas_build::download(&output).unwrap();
         fs::rename(&source_tmp, &source).unwrap();
     }
     for name in &vec!["CC", "FC", "HOSTCC"] {
@@ -268,20 +262,6 @@ fn build() {
         output.join("opt/OpenBLAS/lib").display(),
     );
 
-    fn run(command: &mut Command) {
-        println!("Running: `{:?}`", command);
-        match command.status() {
-            Ok(status) => {
-                if !status.success() {
-                    panic!("Failed: `{:?}` ({})", command, status);
-                }
-            }
-            Err(error) => {
-                panic!("Failed: `{:?}` ({})", command, error);
-            }
-        }
-    }
-
     fn binary() -> &'static str {
         if cfg!(target_pointer_width = "32") {
             "32"