fix: regression for unauthenticated argument handling (#56)

rayozzie · web-flow · commit b8efea063c6e · 2025-10-23T16:14:40.000-07:00
A core function of the notehub CLI is to do things like find out what version of the utility you're running, or setting or clearing out of the "current notehub". Since adding the browser-based functionality, the CLI couldn't do these functions without validating credentials:

notehub -version
notehub -hub -
notehub -hub ray.blues.tools

This PR fixes the regression.
diff --git a/go.mod b/go.mod
@@ -23,6 +23,7 @@ require (
 	github.com/power-devops/perfstat v0.0.0-20240221224432-82ca36839d55 // indirect
 	github.com/rivo/uniseg v0.4.7 // indirect
 	github.com/shirou/gopsutil/v3 v3.24.4 // indirect
+	github.com/shoenig/go-m1cpu v0.1.7 // indirect
 	github.com/tklauser/go-sysconf v0.3.14 // indirect
 	go.bug.st/serial v1.6.2
 	golang.org/x/sys v0.20.0 // indirect
diff --git a/go.sum b/go.sum
@@ -54,8 +54,12 @@ github.com/shirou/gopsutil/v3 v3.24.4 h1:dEHgzZXt4LMNm+oYELpzl9YCqV65Yr/6SfrvgRB
 github.com/shirou/gopsutil/v3 v3.24.4/go.mod h1:lTd2mdiOspcqLgAnr9/nGi71NkeMpWKdmhuxm9GusH8=
 github.com/shoenig/go-m1cpu v0.1.6 h1:nxdKQNcEB6vzgA2E2bvzKIYRuNj7XNJ4S/aRSwKzFtM=
 github.com/shoenig/go-m1cpu v0.1.6/go.mod h1:1JJMcUBvfNwpq05QDQVAnx3gUHr9IYF7GNg9SUEw2VQ=
+github.com/shoenig/go-m1cpu v0.1.7 h1:C76Yd0ObKR82W4vhfjZiCp0HxcSZ8Nqd84v+HZ0qyI0=
+github.com/shoenig/go-m1cpu v0.1.7/go.mod h1:KkDOw6m3ZJQAPHbrzkZki4hnx+pDRR1Lo+ldA56wD5w=
 github.com/shoenig/test v0.6.4 h1:kVTaSd7WLz5WZ2IaoM0RSzRsUD+m8wRR+5qvntpn4LU=
 github.com/shoenig/test v0.6.4/go.mod h1:byHiCGXqrVaflBLAMq/srcZIHynQPQgeyvkvXnjqq0k=
+github.com/shoenig/test v1.7.0 h1:eWcHtTXa6QLnBvm0jgEabMRN/uJ4DMV3M8xUGgRkZmk=
+github.com/shoenig/test v1.7.0/go.mod h1:UxJ6u/x2v/TNs/LoLxBNJRV9DiwBBKYxXSyczsBHFoI=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSSt89Yw=
 github.com/stretchr/objx v0.5.0/go.mod h1:Yh+to48EsGEfYuaHDzXPcE3xhTkx73EhmCGUpEOglKo=
diff --git a/lib/config.go b/lib/config.go
@@ -251,6 +251,12 @@ func GetConfig() (*ConfigSettings, error) {
 			config = defaultConfig()
 		}
 	}
+	if config.IPort == nil {
+		config.IPort = make(map[string]ConfigPort)
+	}
+	if config.HubCreds == nil {
+		config.HubCreds = make(map[string]ConfigCreds)
+	}
 	return config, nil
 }
 
@@ -278,6 +284,12 @@ func ConfigRead() error {
 		return fmt.Errorf("can't parse %s: %s", configPath, err)
 	}
 	config = &newConfig
+	if config.IPort == nil {
+		config.IPort = make(map[string]ConfigPort)
+	}
+	if config.HubCreds == nil {
+		config.HubCreds = make(map[string]ConfigCreds)
+	}
 
 	return nil
 }
@@ -378,8 +390,6 @@ func FlagParse(notecardFlags bool, notehubFlags bool) (err error) {
 		if err := config.Write(); err != nil {
 			return fmt.Errorf("could not write config file: %w", err)
 		}
-		fmt.Printf("configuration file saved\n\n")
-		config.Print()
 	}
 
 	// Override, just for this session, with env vars
diff --git a/notehub/main.go b/notehub/main.go

Original file line number	Diff line number	Diff line change
`@@ -251,6 +251,12 @@ func GetConfig() (*ConfigSettings, error) {`
`251`	`251`	`config = defaultConfig()`
`252`	`252`	`}`
`253`	`253`	`}`
	`254`	`+ if config.IPort == nil {`
	`255`	`+ config.IPort = make(map[string]ConfigPort)`
	`256`	`+ }`
	`257`	`+ if config.HubCreds == nil {`
	`258`	`+ config.HubCreds = make(map[string]ConfigCreds)`
	`259`	`+ }`
`254`	`260`	`return config, nil`
`255`	`261`	`}`
`256`	`262`
`@@ -278,6 +284,12 @@ func ConfigRead() error {`
`278`	`284`	`return fmt.Errorf("can't parse %s: %s", configPath, err)`
`279`	`285`	`}`
`280`	`286`	`config = &newConfig`
	`287`	`+ if config.IPort == nil {`
	`288`	`+ config.IPort = make(map[string]ConfigPort)`
	`289`	`+ }`
	`290`	`+ if config.HubCreds == nil {`
	`291`	`+ config.HubCreds = make(map[string]ConfigCreds)`
	`292`	`+ }`
`281`	`293`
`282`	`294`	`return nil`
`283`	`295`	`}`
`@@ -378,8 +390,6 @@ func FlagParse(notecardFlags bool, notehubFlags bool) (err error) {`
`378`	`390`	`if err := config.Write(); err != nil {`
`379`	`391`	`return fmt.Errorf("could not write config file: %w", err)`
`380`	`392`	`}`
`381`		`- fmt.Printf("configuration file saved\n\n")`
`382`		`- config.Print()`
`383`	`393`	`}`
`384`	`394`
`385`	`395`	`// Override, just for this session, with env vars`