Merge pull request #301 from boostcampwm-2022/develop

v0.2.0 배포

Author: asdf99245

README.md

@@ -1,5 +1,7 @@
 # <img src="https://user-images.githubusercontent.com/79798443/206173852-a4baafe3-5de7-4afa-b494-f630d5170d54.svg"/> Devrank <img src="https://user-images.githubusercontent.com/79798443/206173852-a4baafe3-5de7-4afa-b494-f630d5170d54.svg"/>
 
+[![Hits](https://hits.seeyoufarm.com/api/count/incr/badge.svg?url=https%3A%2F%2Fgithub.com%2Fboostcampwm-2022%2Fweb21-devrank&count_bg=%23C455F9&title_bg=%23555555&icon=&icon_color=%23E7E7E7&title=hits&edge_flat=false)](https://hits.seeyoufarm.com)
+
 ![Frame 12023](https://user-images.githubusercontent.com/79798443/206137429-5cb1d269-4bec-4aaa-85ad-053ae564c625.png)
 
 **_Devrank_** 는 게임과 유사한 등급 시스템과 랭킹을 제공하여, Github 활동시 사용자에게 성취감을 주고 오픈소스 활동을 장려하는 서비스 입니다.

backend/src/batch/batch.service.ts

@@ -8,7 +8,7 @@ import { UserService } from '../user/user.service';
 export class BatchService {
   constructor(private readonly userService: UserService, private readonly configService: ConfigService) {}
 
-  @Cron('0 0 0 * * *', { name: 'cronTask' })
+  @Cron('0 0 0 * * *', { name: 'cronTask', timeZone: 'Asia/Seoul' })
   handleCron() {
     logger.log('Task Called');
     this.userService.dailyUpdateAllUsers(this.configService.get('GITHUB_PERSONAL_ACCESS_TOKEN'));

backend/src/user/user.controller.ts

@@ -6,6 +6,7 @@ import {
   Controller,
   DefaultValuePipe,
   Get,
+  NotFoundException,
   Param,
   ParseIntPipe,
   Patch,
@@ -74,18 +75,15 @@ export class UserController {
     @Param('username') username: string,
   ): Promise<UserProfileDto> {
     const lowerUsername = username.toLowerCase();
-    if (
-      (await this.userService.findUpdateScoreTimeToLive(lowerUsername)) > 0 &&
-      (await this.userService.findOneByFilter({ lowerUsername }))?.id !== id
-    ) {
+    const targetUser = await this.userService.findOneByFilter({ lowerUsername });
+    if ((await this.userService.findUpdateScoreTimeToLive(lowerUsername)) > 0 && targetUser?.id !== id) {
       throw new BadRequestException('user score has been updated recently.');
     }
+    await this.userService.setUpdateScoreDelayTime(lowerUsername, UPDATE_DELAY_TIME);
     const user = await this.userService.updateUser(
       lowerUsername,
       githubToken || this.configService.get('GITHUB_PERSONAL_ACCESS_TOKEN'),
     );
-
-    await this.userService.setUpdateScoreDelayTime(lowerUsername, UPDATE_DELAY_TIME);
     user.updateDelayTime = UPDATE_DELAY_TIME + 3;
     return user;
   }

backend/src/user/user.service.ts

@@ -32,32 +32,28 @@ export class UserService {
   }
 
   async findOneByUsername(githubToken: string, ip: string, lowerUsername: string): Promise<UserProfileDto> {
-    let user = null;
-    if (await this.userRepository.isDuplicatedRequestIp(ip, lowerUsername)) {
-      user = await this.userRepository.findOneByLowerUsername(lowerUsername);
-    } else {
-      user = await this.userRepository.findOneByLowerUsernameAndUpdateViews(lowerUsername);
-    }
-
+    let user = await this.userRepository.findOneByLowerUsername(lowerUsername);
     if (!user) {
-      user = await this.updateUser(lowerUsername, githubToken);
-      if (!user.scoreHistory) {
-        user.scoreHistory = [];
+      try {
+        user = await this.updateUser(lowerUsername, githubToken);
+        if (!user.scoreHistory) {
+          user.scoreHistory = [];
+        }
+        user.scoreHistory.push({ date: new Date(), score: user.score });
+        user = await this.userRepository.createOrUpdate(user);
+      } catch {
+        throw new HttpException(`can't update this user.`, HttpStatus.NO_CONTENT);
       }
-      user.scoreHistory.push({ date: new Date(), score: user.score });
-      user = await this.userRepository.createOrUpdate(user);
     }
-    await this.userRepository.createOrUpdate(user);
-
     const { totalRank, tierRank } =
       (await this.getUserRelativeRanking(user)) || (await this.setUserRelativeRanking(user));
+    if (!(await this.userRepository.isDuplicatedRequestIp(ip, lowerUsername)) && user.history) {
+      user.dailyViews += 1;
+      await this.userRepository.createOrUpdate(user);
+    }
     this.userRepository.setDuplicatedRequestIp(ip, lowerUsername);
     user.updateDelayTime = await this.userRepository.findUpdateScoreTimeToLive(lowerUsername);
-    user.totalRank = totalRank;
-    user.tierRank = tierRank;
-    user.startExp = getStartExp(user.score);
-    user.needExp = getNeedExp(user.score);
-    return user;
+    return { ...user, totalRank, tierRank, startExp: getStartExp(user.score), needExp: getNeedExp(user.score) };
   }
 
   async findAllByPrefixUsername(limit: number, lowerUsername: string): Promise<AutoCompleteDto[]> {
@@ -83,6 +79,24 @@ export class UserService {
       organizations,
       pinnedRepositories,
     };
+    if (!updatedUser.scoreHistory) {
+      updatedUser.scoreHistory = [];
+    }
+    const KR_TIME_DIFF = 9 * 60 * 60 * 1000;
+    const utc = updatedUser.scoreHistory[updatedUser.scoreHistory.length - 1].date.getTime();
+    if (new Date(utc + KR_TIME_DIFF).getDate() == new Date().getDate()) {
+      updatedUser.scoreHistory.pop();
+    }
+    updatedUser.scoreHistory.push({
+      date: new Date(),
+      score: updatedUser.score,
+    });
+    if (updatedUser.scoreHistory.length > 1) {
+      updatedUser.scoreDifference =
+        updatedUser.score - updatedUser.scoreHistory[updatedUser.scoreHistory.length - 2].score;
+    } else {
+      updatedUser.scoreDifference = 0;
+    }
     user = await this.userRepository.createOrUpdate(updatedUser);
     const { totalRank, tierRank } = await this.setUserRelativeRanking(user);
     const userWithRank: UserProfileDto = {
@@ -102,15 +116,6 @@ export class UserService {
       await sleep(GITHUB_API_DELAY);
       try {
         const updateUser = await this.updateUser(user.lowerUsername, githubToken);
-        if (!updateUser.scoreHistory) updateUser.scoreHistory = [];
-        if (updateUser.scoreHistory.length) updateUser.scoreHistory.pop();
-        updateUser.scoreHistory.push({ date: new Date(), score: updateUser.score });
-        if (updateUser.scoreHistory.length > 1) {
-          updateUser.scoreDifference =
-            updateUser.score - updateUser.scoreHistory[updateUser.scoreHistory.length - 2].score;
-        } else {
-          updateUser.scoreDifference = 0;
-        }
         this.userRepository.createOrUpdate(updateUser);
         this.userRepository.deleteCachedUserRank(updateUser.lowerUsername + '&');
       } catch {
@@ -126,17 +131,6 @@ export class UserService {
       await sleep(GITHUB_API_DELAY);
       try {
         const updatedUser = await this.updateUser(user.lowerUsername, githubToken);
-        if (!updatedUser.scoreHistory) updatedUser.scoreHistory = [];
-        updatedUser.scoreHistory.push({
-          date: new Date(),
-          score: updatedUser.score,
-        });
-        if (updatedUser.scoreHistory.length > 1) {
-          updatedUser.scoreDifference =
-            updatedUser.score - updatedUser.scoreHistory[updatedUser.scoreHistory.length - 2].score;
-        } else {
-          updatedUser.scoreDifference = 0;
-        }
         updatedUser.dailyViews = 0;
         this.userRepository.createOrUpdate(updatedUser);
       } catch {
@@ -202,20 +196,16 @@ export class UserService {
         username: lowerUsername,
         id,
       });
-
       const personalResponse: any = await octokit.graphql(nonForkRepositoryQuery, {
         username: lowerUsername,
         id,
       });
-
       const followersResponse: any = await octokit.graphql(followersQuery, {
         username: lowerUsername,
       });
-
       const issuesResponse: any = await octokit.graphql(issueQuery, {
         username: lowerUsername,
       });
-
       let languagesScore = new Map();
       function getCommitScore(acc: number, repository) {
         if (!repository.defaultBranchRef) {

frontend/public/icons/cube-large-background.svg

@@ -6,5 +6,7 @@
   "user-update-delay": "You can update it in",
   "day": "day",
   "total": "Total",
-  "rank": "Rank"
+  "rank": "Rank",
+  "invalid-user": "This user cannot get information",
+  "invalid-rank": "Unable to get the rank"
 }

frontend/public/icons/cube/cube-small-invalid.svg

@@ -6,5 +6,7 @@
   "user-update-delay": "초 후 업데이트 가능합니다.",
   "day": "일",
   "total": "전체",
-  "rank": "등급"
+  "rank": "등급",
+  "invalid-user": "정보를 가져올 수 없는 유저입니다",
+  "invalid-rank": "등수를 표시할 수 없습니다"
 }

frontend/public/locales/en/profile.json

@@ -20,6 +20,7 @@ function LineChart({ data, min, max, markers, tooltip }: LineChartProps) {
         margin={{ top: 60, right: 60, bottom: 60, left: 60 }}
         curve='monotoneX'
         enableArea={true}
+        areaBaselineValue={min || 0}
         xScale={{
           type: 'time',
           format: '%Y-%m-%d',

frontend/public/locales/ko/profile.json

@@ -29,7 +29,7 @@
     "legend": {
       "text": {
         "fontSize": 14,
-        "fontWeight": 700,
+        "fontWeight": 400,
         "fill": "#FBFBFB"
       }
     },
@@ -39,7 +39,8 @@
         "strokeWidth": 1
       },
       "text": {
-        "fontSize": 14,
+        "fontSize": 12,
+        "fontWeight": 100,
         "fill": "#FBFBFB"
       }
     }