Skip to content

Commit 4cd1875

Browse files
authored
Merge pull request #306 from boostcampwm-2022/feature/intro
Feature: 소개 페이지 개발자 소개 수정
2 parents 54675df + 07bbc0a commit 4cd1875

File tree

2 files changed

+30
-19
lines changed

2 files changed

+30
-19
lines changed

frontend/src/pages/about.tsx

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { GetStaticProps } from 'next';
22
import { useTranslation } from 'next-i18next';
33
import Image from 'next/image';
4+
import Link from 'next/link';
45
import React from 'react';
56
import styled from 'styled-components';
67
import { CubeIcon } from '@components/common';
@@ -107,18 +108,28 @@ function About() {
107108
</Content>
108109
<Content>
109110
<Title>Developed By</Title>
110-
{DEVELOPER_INFORMATION.map(({ name, introduction, field, career }) => (
111+
{DEVELOPER_INFORMATION.map(({ name, introduction, github, blog, email, field }) => (
111112
<Profile key={name}>
112113
<Name>
113114
{name}
114115
<div>
115-
<Image src='/icons/github.svg' alt='깃허브 아이콘' width={20} height={20} quality={100} />
116-
<Image src='/icons/link.svg' alt='링크 아이콘' width={20} height={20} quality={100} />
116+
<Link href={github} legacyBehavior>
117+
<a>
118+
<Image src='/icons/github.svg' alt='깃허브 아이콘' width={20} height={20} quality={100} />
119+
</a>
120+
</Link>
121+
{blog && (
122+
<Link href={blog} legacyBehavior>
123+
<a>
124+
<Image src='/icons/link.svg' alt='링크 아이콘' width={20} height={20} quality={100} />
125+
</a>
126+
</Link>
127+
)}
117128
</div>
118129
</Name>
119130
<Description>
120-
<li>&middot; 개발경력 : {career}</li>
121131
<li>&middot; 담당 : {field}</li>
132+
<li>&middot; 이메일: {email}</li>
122133
<li>&middot; {introduction}</li>
123134
</Description>
124135
</Profile>
@@ -226,10 +237,10 @@ const Profile = styled.div`
226237
`;
227238

228239
const Name = styled.div`
240+
${({ theme }) => theme.common.flexRow}
229241
font-size: ${({ theme }) => theme.fontSize.xl};
230242
color: ${({ theme }) => theme.colors.logo};
231243
margin-left: 20px;
232-
${({ theme }) => theme.common.flexCenter}
233244
gap: 10px;
234245
`;
235246

frontend/src/utils/constants.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -49,35 +49,35 @@ export const CUBE_RANK = {
4949
export const DEVELOPER_INFORMATION = [
5050
{
5151
name: '장우석',
52-
github: '',
53-
blog: '',
54-
career: '1년',
52+
github: 'https://github.com/wkddntjr1123',
53+
blog: 'https://wkddntjr1123.github.io/',
5554
field: 'Backend',
56-
introduction: '안녕하세요. 장우석입니다.',
55+
56+
introduction: '함께 일하고싶은 개발자 장우석입니다. 커피☕ 사주세요!',
5757
},
5858
{
5959
name: '강시온',
60-
github: '',
61-
blog: '',
62-
career: '?년',
60+
github: 'https://github.com/Yaminyam',
61+
blog: 'https://velog.io/@siontama',
6362
field: 'Backend',
64-
introduction: '안녕하세요. 강시온입니다.',
63+
64+
introduction: '개발자를 위한 개발자 강시온 입니다',
6565
},
6666
{
6767
name: '정윤규',
68-
github: '',
68+
github: 'https://github.com/asdf99245',
6969
blog: '',
70-
career: '1년',
7170
field: 'Frontend',
72-
introduction: '안녕하세요. 정윤규입니다.',
71+
72+
introduction: '사용자를 먼저 이해하는 프론트엔드 엔지니어 정윤규입니다.',
7373
},
7474
{
7575
name: '정성윤',
76-
github: '',
76+
github: 'https://github.com/tunggary',
7777
blog: '',
78-
career: '1년',
7978
field: 'Frontend',
80-
introduction: '안녕하세요. 정성윤입니다.',
79+
80+
introduction: '최적화에 관심이 많은 프론트엔드 개발자 정성윤입니다.',
8181
},
8282
];
8383

0 commit comments

Comments
 (0)