FFProbeStream is missing "color_space" attribute

[AlexanderSchuetz97]

Is your feature request related to a problem? Please describe.
I need to ensure that some videos have a specific color space.
To check this I would like to use ffprobe and if they dont have said color space then
I have to take some other unrelated action.

Describe the solution you'd like
Simply add the following elements to the FFmpegStream
example from the raw ffprobe json:

{
  "streams" : [ {
  ///.... irrelevant
    "color_range" : "tv",
    "color_space" : "reserved",
    "color_transfer" : "arib-std-b67",
    "color_primaries" : "bt2020",
///.... irrelevant

gson will take care of the rest

Describe alternatives you've considered
Subclassing everything, but at that point I may aswell just not use this cli wrapper.

[bramp]

Seems totally reasonable. I'll happily accept a pull request adding this to the models, with appropriate tests.

[AlexanderSchuetz97]

Ill see about doing it, could you elaborate what you consider an appropriate test?

I am not sure if I will be able to commit a testfile to this repository as I do not own the copyright of the files I am working with.
Testing if a raw dump from ffprobe can be parsed should not be a problem.

Edit: I have talked to my boss about doing this, he says that I can do it but not right now. So I will get to doing this in 1-2 months. I suppose we can just let this issue sit and I will get to it when I have time.

[bramp]

Test is just a "dump" of the ffprobe output. No need for the actual media. You could even edit the existing test data if that's easier.

See src/test/java/net/bramp/ffmpeg/FFprobeTest.java and the files prefixed with ffprobe here: src/test/resources/net/bramp/ffmpeg/fixtures.

The bug can remain open until you have time to work on this, or someone else gets to it first.