Skip to content

Commit ed920b4

Browse files
committed
Clean code and required changes made
1 parent ba0e18c commit ed920b4

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -441,10 +441,10 @@ strict-transport-security: max-age=31536000; includeSubDomains; preload
441441

442442
If Strict-Transport-Security is not enough to accomplish a forwarding connection to HTTPS from the browsers, you can opt to add an additional middleware who provides this redirection if clients try to reach your site with an HTTP connection.
443443

444-
To use the HSTS Redirect Middleware, you can add the following line in your middlewares, preferably before securityHeadersFactory.build():
444+
To use the HTTPS Redirect Middleware, you can add the following line in **configure.swift** to enable the middleware. This must be done before `securityHeadersFactory.build()` to ensure HSTS works:
445445

446446
```swift
447-
app.middleware.use(securityHeadersFactory.redirectMiddleware)
447+
app.middleware.use(HTTPSRedirectMiddleware())
448448
```
449449

450450
## Server

Sources/VaporSecurityHeaders/Configurations/HSTSRedirectMiddleware.swift renamed to Sources/VaporSecurityHeaders/Configurations/HTTPSRedirectMiddleware.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
import Vapor
22

3-
public class HSTSRedirectMiddleware: Middleware {
3+
public class HTTPSRedirectMiddleware: Middleware {
44

5+
public init() {}
6+
57
public func respond(to request: Request, chainingTo next: Responder) -> EventLoopFuture<Response> {
68
if request.application.environment == .development {
79
return next.respond(to: request)

Sources/VaporSecurityHeaders/SecurityHeadersFactory.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ public class SecurityHeadersFactory {
99
var server: ServerConfiguration?
1010
var referrerPolicy: ReferrerPolicyConfiguration?
1111
var contentSecurityPolicyReportOnly: ContentSecurityPolicyReportOnlyConfiguration?
12-
public var redirectMiddleware = HSTSRedirectMiddleware()
1312

1413
public init() {}
1514

Tests/VaporSecurityHeadersTests/RedirectionTest.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class RedirectionTest: XCTestCase {
6565
application.environment = environment
6666
}
6767
if withRedirection == true {
68-
application.middleware.use(SecurityHeadersFactory().redirectMiddleware)
68+
application.middleware.use(HTTPSRedirectMiddleware())
6969
}
7070
try routes(application)
7171
return try application.responder.respond(to: request).wait()

0 commit comments

Comments
 (0)