fix: semver bug #376
Open
fix: semver bug #376
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asteurer
force-pushed
the
asteurer-semver-fix
branch
2 times, most recently
from
69a9bbd to
2b382e6
Compare
Member
|
@ydnar is there any way Andrew could get a review for this? And more generally, I just talked to Andrew, and he's interested in potentially doing more work here, very much including bug fixes. That of course only makes sense if there's a way to land changes. Is that something he could assume, or would it be better to hold off on contributions for now? |
…with a digit from packages using valid semver Signed-off-by: Andrew Steurer <[email protected]> fix: bug that incorrectly generates WIT worlds with words that start with a digit from packages using valid semver Signed-off-by: Andrew Steurer <[email protected]>
asteurer
force-pushed
the
asteurer-semver-fix
branch
from
2b382e6 to
fad3c1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #371