Switching main output from object to array, to simplify external iteration

Author: snelg

src/BYUJWT.php

@@ -170,8 +170,13 @@ public static function validateJWT($jwt)
     public static function decode($jwt)
     {
         $key = static::getPublicKey();
-        $decoded = JWT::decode($jwt, $key, ['HS256','RS256','HS512','HS384']);
-        if (empty($decoded->exp)) {
+        $decodedObject = JWT::decode($jwt, $key, ['HS256','RS256','HS512','HS384']);
+
+        //JWT::decode returns at stdClass object, but iterating through keys is much
+        //simpler with an array. So here's a quick Object-to-Array conversion
+        $decoded = json_decode(json_encode($decodedObject), true);
+
+        if (empty($decoded['exp'])) {
             //Firebase\JWT\JWT::decode does not throw an error if "exp" does not exist,
             //although it does throw an error if it exists but has already passed
             //For BYU we want to ensure that it does exist, as well as being valid

tests/BYUJWTTest.php

@@ -115,7 +115,7 @@ public function testJWTWithNoExpiration()
     {
         //Validation should be false when Expiration does not exist in an otherwise valid JWT
         $decoded = BYUJWT::decode(static::$validJWT);
-        unset($decoded->exp);
+        unset($decoded['exp']);
         $badJwt = JWT::encode($decoded, BYUJWT::getPublicKey());
 
         $this->assertSame(false, BYUJWT::validateJWT($badJwt));
@@ -137,7 +137,7 @@ public function testJTWDecodeSuccesful()
     {
         $decodedJwt = BYUJWT::decode(static::$validJWT);
         $this->assertNotEmpty($decodedJwt);
-        $this->assertEquals('https://api.byu.edu', $decodedJwt->iss);
-        $this->assertEquals(static::$credentials->client_id, $decodedJwt->{'http://wso2.org/claims/client_id'});
+        $this->assertEquals('https://api.byu.edu', $decodedJwt['iss']);
+        $this->assertEquals(static::$credentials->client_id, $decodedJwt['http://wso2.org/claims/client_id']);
     }
 }