Unable to generate json output using --format flag

[r0075h3ll]

Hi There

I'm unable to generate json output for a malware scan using this command: mal scan -i metal3d/xmrig --format=json

Output

Incorrect Usage: flag provided but not defined: -format

NAME:
   malcontent analyze - fully interrogate a path

USAGE:
   malcontent analyze command [command options]

COMMANDS:
   help, h  Shows a list of commands or help for one command

OPTIONS:
   --image value, -i value  Scan an image
   --processes              Scan the commands (paths) of running processes (default: false)
   --help, -h               show help
💣 flag provided but not defined: -format

Thanks

[tstromberg]

malcontent currently requires global flags to be provided before the sub-command. Try this:

mal --format=json scan -i metal3d/xmrig

This quirk trips me up all the time; I think this is good evidence that we should consider changing our flag handling so that global flags (ones that can be applied to multiple subcommands) can be specified anywhere.

[r0075h3ll]

Hi @tstromberg, this works, thank you.

Also, regarding the flags, mind if I take a look and raise a PR for the same?

[tstromberg]

Yes! That would be excellent. Thank you!

…

On Mon, Feb 10, 2025, 9:22 PM Hardik Nanda ***@***.***> wrote: Hi @tstromberg <https://github.com/tstromberg>, this works, thank you. Also, regarding the flags, mind if I take a look and raise a PR for the same? — Reply to this email directly, view it on GitHub <#796 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYYMB7HIJKDKKD7KWUY3L2PFUIZAVCNFSM6AAAAABW2FQWXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBZG4ZDENJUGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[krisharyan]

Hello @tstromberg can I work on this issue? I searched for ways to make this possible and I have come up with 2 solutions:

1. (Not Recommended) Create a helper function that will rearrange all the global flags to appear before the subcommand. The Catch? We will have to name our local and global flags uniquely. No local flag should have the same name as global flag because if we do that then the helper function will drag it before the subcommand and that's not what we want.

2.(Will need refactor from urfave:v2 to urfave:v3) We use the persistant flags feature in urfave:v3 that will solve our problem but we will need to refactor