Skip to content

ci: fix exp/teatest tests on windows #389

@andreynering

Description

@andreynering

We did a fix recently about golden files on Windows: #365

That fixed many tests on Windows, but on this repository two started failing. We need to figure it out if there is a better way this the below to handle \r\n golden files checkout by Git on Windows.

x/exp/golden/golden.go

Lines 78 to 80 in 59292a3

if runtime.GOOS == "windows" {
return strings.ReplaceAll(str, "\r\n", "\n")
}

Perhaps we can remove the fix done on #365 and replace it by a .gitattributes file instructing Git to preserve *.golden files as is? We'd need to do this on all relevant repositories, though, not only on this one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions