-
Notifications
You must be signed in to change notification settings - Fork 44
Open
Description
We did a fix recently about golden files on Windows: #365
That fixed many tests on Windows, but on this repository two started failing. We need to figure it out if there is a better way this the below to handle \r\n golden files checkout by Git on Windows.
Lines 78 to 80 in 59292a3
| if runtime.GOOS == "windows" { | |
| return strings.ReplaceAll(str, "\r\n", "\n") | |
| } |
Perhaps we can remove the fix done on #365 and replace it by a .gitattributes file instructing Git to preserve *.golden files as is? We'd need to do this on all relevant repositories, though, not only on this one.
caarlos0aymanbagabas
Metadata
Metadata
Assignees
Labels
No labels