Skip to content

Drop Python 3.9 #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 1, 2025
Merged

Drop Python 3.9 #338

merged 10 commits into from
Nov 1, 2025

Conversation

@tony
Copy link
Member

@tony tony commented Nov 1, 2025 •
edited
Loading

@codecov
Copy link

codecov bot commented Nov 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.03%. Comparing base (e766fce) to head (4b0c8c5).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/unihan_etl/core.py 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   70.03%   70.03%           
=======================================
  Files          13       13           
  Lines        1325     1325           
  Branches      114      114           
=======================================
  Hits          928      928           
  Misses        372      372           
  Partials       25       25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tony added 10 commits November 1, 2025 10:33
@tony
ci(tests) Drop Python 3.9
ca518ee 
See also:
- https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596
- https://peps.python.org/pep-0596/
@tony
pyproject(requires-python) 3.9 -> 3.10 minimum
6f5b172 
See also:
- https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596
- https://peps.python.org/pep-0596/
@tony
pyproject(trove classifiers) Drop Python 3.9
4a15627 
See also:
- https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596
- https://peps.python.org/pep-0596/
@tony
pyproject(tool.ruff) Bump target-version py39 -> py310
ee88c1f 
See also:
- https://docs.astral.sh/ruff/settings/#target-version
- Python 3.9 EOL:
  - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596
  - https://peps.python.org/pep-0596/
@tony
pyproject(tool.mypy) Bump python_version 3.9 -> 3.10
0b06c3b 
See also:
- https://mypy.readthedocs.io/en/stable/config_file.html#confval-python_version
- Python 3.9 EOL:
  - https://devguide.python.org/versions/#:~:text=Release%20manager-,3.9,-PEP%20596
  - https://peps.python.org/pep-0596/
@tony
chore(ruff): Autofixes for ruff with Python 3.10+
ae37c14 
Fixed 11 errors:
- src/unihan_etl/__main__.py:
    1 × UP007 (non-pep604-annotation-union)
    1 × UP035 (deprecated-import)
    1 × UP045 (non-pep604-annotation-optional)
- src/unihan_etl/core.py:
    1 × I001 (unsorted-imports)
    1 × UP035 (deprecated-import)
- src/unihan_etl/expansion.py:
    1 × I001 (unsorted-imports)
    1 × UP035 (deprecated-import)
- src/unihan_etl/types.py:
    1 × I001 (unsorted-imports)
    1 × UP035 (deprecated-import)
- tests/_internal/test_app_dirs.py:
    1 × UP007 (non-pep604-annotation-union)
- tests/test_expansion.py:
    1 × UP035 (deprecated-import)

Found 12 errors (11 fixed, 1 remaining).
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).
@tony
chore: Manual fixes for Python 3.10+ support
dfa2349 
- Add explicit strict=False to zip() calls to satisfy B905 linter check
@tony
chore(ruff): Unsafe fixes for Python 3.10+
13d2eb2 
- Convert f-string logging statements to % formatting for better logging performance (G004 fix)

This commit applies unsafe ruff fixes from --unsafe-fixes including:
- Logging format improvements
- Type annotation modernization

All tests passing after changes.
@tony
docs(CHANGES) Note Python 3.9 being dropped
ae872c7
@tony
py(deps) Bump for 3.10+ via uv sync --all-extras --dev --upgrade
4b0c8c5
@tony tony merged commit 95c92e9 into master Nov 1, 2025
12 checks passed
@tony tony deleted the drop-python-3.9 branch November 1, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tony