use jsonchecker.JsonTestExpect() for negative tests

[kkourt]

In some cases, we want to test for the absence of certain events.

Some tests use something like the following to do this:

err := jsonchecker.JsonTestCheck(t, checker)
require.Error(t, err)

The problem with above is that JsonTestCheck does some tricks to keep the event log if there is a failure, so it needs to understand what a failure is. Hence, using jsonchecker.JsonTestExpect with expectCheckerFailure=true is a better approach. We should fix this in the existing tests.

[andrewstrohman]

I think there is a typo in the description.
jsonchecker.JsonTestExpect -> jsonchekcer.JsonTestCheckExpect

[GGh41th]

After a quick look , we only have this case in the tests for the kprobes , i can fix them if you'd like.
Just to make sure that i understood the issue correctly , aside of using jsonchekcer.JsonTestCheckExpect , the only change will be to require a NoError right? since the returned err will be a nil.

[andrewstrohman]

Just to make sure that i understood the issue correctly , aside of using jsonchekcer.JsonTestCheckExpect , the only change will be to require a NoError right? since the returned err will be a nil.

Yes. This issue was created because of feedback for my PR, and that was the resolution for me.